Re: [v2 PATCH 0/4] IPVS: Backup Adding Ipv6 and Persistence support

[Hans Schillstrom <hans@schillstrom.com>]

On Monday, November 08, 2010 23:00:29 Simon Horman wrote:
> On Mon, Nov 08, 2010 at 04:15:10PM +0100, Hans Schillstrom wrote:
> > On Monday 08 November 2010 07:21:23 Simon Horman wrote:
> > [ snip ]
> > 
> > > How about this, which applies on top of
> > > "IPVS: Add persistence engine to connection entry".
> > >
> > > From: Simon Horman <horms@verge.net.au>
> > > Subject: IPVS: Only match pe_data created by the same pe
> > >
> > > Only match persistence engine data if it was
> > > created by the same persistence engine.
> > >
> > > Reported-by: Julian Anastasov <ja@ssi.bg>
> > > Signed-off-by: Simon Horman <horms@verge.net.au>
> > 
> > Thanks I'll will use that one,
> > I think it's time to cook a new backup patch,
> > or do any one have more patches in the pipe ?
> 
> I have added this and the other patches that I am completely happy with
> to the staging branch of lvs-test-2.6.
> 
> Specifically the patches in there are:
> 
> * IPVS: Only match pe_data created by the same pe
> * IPVS: Add persistence engine to connection entry
> * IPVS: Backup, Adding structs for new sync format
> * IPVS: Prepare for transferring firewall marks (fwmark) to the backup daemon.
> * IPVS: ip_vs_pe.c, use strncmp to be safe.
> 
> If you are unhappy with any of those changes let me know,
> I'm happy to revert and rebase the staging branch
> (its mainly for your benefit at this stage).

Thanks a lot,
I will start with the cooking tomorrow, with lvs-test-2.6 as my base

> 
> I would also like to add the following clean-up changes,
> could I get an Ack or Nack from you on each of them?
> 
> * IPVS: Make the cp argument to ip_vs_sync_conn() static
>   http://www.spinics.net/lists/lvs-devel/msg01375.html
ACK,
I'll do the same in the last patch for _v0/_v1 sending

> * IPVS: Remove useless { } block from ip_vs_process_message()
>   http://www.spinics.net/lists/lvs-devel/msg01369.html
ACK,

> * IPVS: buffer argument to ip_vs_process_message() should not be const
>   http://www.spinics.net/lists/lvs-devel/msg01377.html
> 
ACK

Thanks,
 Hans