All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Greg KH <greg@kroah.com>,
	Omar Ramirez Luna <omar.ramirez@ti.com>,
	Paul Walmsley <paul@pwsan.com>,
	Fernando Guzman Lugo <fernando.lugo@ti.com>
Subject: Re: [PATCH 1/5] omap: dsp: remove shm from normal memory
Date: Mon, 8 Nov 2010 16:53:21 -0800	[thread overview]
Message-ID: <20101109005320.GW9264@atomide.com> (raw)
In-Reply-To: <1289166209-32251-2-git-send-email-felipe.contreras@gmail.com>

* Felipe Contreras <felipe.contreras@gmail.com> [101107 13:34]:
> Also, don't be picky about the location, which incidentally fixes the
> build since MEMBLOCK_REAL_LIMIT is gone on 2.6.37.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

This is a valid fix for 2.6.37 -rc cycle now that the memblock code
is in and should get merged with other drivers/staging/tidspbridge
related fixes.

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/plat-omap/devices.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/devices.c b/arch/arm/plat-omap/devices.c
> index 6f42a18..fc81912 100644
> --- a/arch/arm/plat-omap/devices.c
> +++ b/arch/arm/plat-omap/devices.c
> @@ -284,12 +284,14 @@ void __init omap_dsp_reserve_sdram_memblock(void)
>  	if (!size)
>  		return;
>  
> -	paddr = __memblock_alloc_base(size, SZ_1M, MEMBLOCK_REAL_LIMIT);
> +	paddr = memblock_alloc(size, SZ_1M);
>  	if (!paddr) {
>  		pr_err("%s: failed to reserve %x bytes\n",
>  				__func__, size);
>  		return;
>  	}
> +	memblock_free(paddr, size);
> +	memblock_remove(paddr, size);
>  
>  	omap_dsp_phys_mempool_base = paddr;
>  }
> -- 
> 1.7.3.2.3.gf8529
> 

  reply	other threads:[~2010-11-09  0:53 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-07 21:36 [GIT PULL] fixes for tidspbridge 2.6.37-rc1 Felipe Contreras
2010-11-07 21:43 ` [PATCH 0/5] omap: dsp: fixes for 2.6.37-rc1 Felipe Contreras
2010-11-07 22:02   ` Greg KH
2010-11-07 22:48     ` Felipe Contreras
2010-11-08 16:45       ` Tony Lindgren
2010-11-08 19:16         ` Tony Lindgren
2010-11-08 22:56           ` Felipe Contreras
2010-11-09  0:51             ` Tony Lindgren
2010-12-15  6:00   ` Paul Walmsley
2010-12-15 13:04     ` Felipe Contreras
2010-11-07 21:43 ` [PATCH 1/5] omap: dsp: remove shm from normal memory Felipe Contreras
2010-11-09  0:53   ` Tony Lindgren [this message]
2010-11-09  1:00     ` Greg KH
2010-11-07 21:43 ` [PATCH 2/5] omap: control: add functions for DSP boot Felipe Contreras
2010-11-11  0:00   ` Paul Walmsley
2010-11-11 11:12     ` Felipe Contreras
2010-11-11 15:26       ` Paul Walmsley
2010-11-07 21:43 ` [PATCH 3/5] omap: pm: use control functions in DSP reset code Felipe Contreras
2010-11-07 21:43 ` [PATCH 4/5] omap: dsp: add boot control functions Felipe Contreras
2010-11-07 21:43 ` [PATCH 5/5] staging: tidspbridge: use " Felipe Contreras
2010-11-08 23:00 ` [GIT PULL] fixes for tidspbridge 2.6.37-rc1 Felipe Contreras
2010-11-09  0:57   ` Tony Lindgren
2010-11-09 16:29   ` Arnd Bergmann
2010-11-09 16:46     ` Guzman Lugo, Fernando
2010-11-09 17:35       ` Tony Lindgren
2010-11-09 17:52         ` Guzman Lugo, Fernando
2010-11-09 18:32           ` Tony Lindgren
2010-11-09 22:13             ` Felipe Contreras
2010-11-09 22:13               ` Felipe Contreras
2010-11-09 21:26           ` Felipe Contreras
2010-11-09 16:55     ` Greg KH
2010-11-09 17:04       ` Guzman Lugo, Fernando
2010-11-09 17:04         ` Guzman Lugo, Fernando
2010-11-09 17:25         ` Greg KH
2010-11-09 17:25           ` Greg KH
2010-11-09 17:49           ` Guzman Lugo, Fernando
2010-11-09 17:49             ` Guzman Lugo, Fernando
2010-11-09 17:58             ` Greg KH
2010-11-09 17:58               ` Greg KH
2010-11-09 18:40               ` Ramirez Luna, Omar
2010-11-09 18:40                 ` Ramirez Luna, Omar
2010-11-09 21:53               ` Felipe Contreras
2010-11-09 21:53                 ` Felipe Contreras
2010-11-09 22:10                 ` Greg KH
2010-11-09 22:39                   ` Felipe Contreras
2010-11-09 22:52                     ` Greg KH
2010-11-09 22:04     ` Felipe Contreras
2010-11-09 22:04       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109005320.GW9264@atomide.com \
    --to=tony@atomide.com \
    --cc=felipe.contreras@gmail.com \
    --cc=fernando.lugo@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=omar.ramirez@ti.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.