diff for duplicates of <20101109134644.GA3163@debian> diff --git a/a/1.txt b/N1/1.txt index e6c7b25..c9f4846 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,21 +1,21 @@ On Mon, Nov 08, 2010 at 10:42:57AM +0000, Catalin Marinas wrote: -> 2010/11/8 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>: +> 2010/11/8 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > > On Sat, Nov 06, 2010 at 07:06:28PM +0000, Catalin Marinas wrote: > >> On Saturday, November 6, 2010, Rabin Vincent <rabin@rab.in> wrote: > >> > --- a/kernel/trace/Kconfig > >> > +++ b/kernel/trace/Kconfig > >> > @@ -141,6 +141,7 @@ config FUNCTION_TRACER > >> > -> >> > ?config FUNCTION_GRAPH_TRACER -> >> > ?? ? ? ?bool "Kernel Function Graph Tracer" -> >> > + ? ? ? select FRAME_POINTER if ARM_UNWIND +> >> > config FUNCTION_GRAPH_TRACER +> >> > bool "Kernel Function Graph Tracer" +> >> > + select FRAME_POINTER if ARM_UNWIND > >> > >> Would it be better to modify FRAME_POINTER definition in the ARM > >> Kconfig so that it is enabled automatically when FUNCTION_GRAPH_TRACER > >> is enabled? > > I don't like that suggestion much because it hides the dependency. > > Moreover a "default y if FUNCTION_GRAPH_TRACER" doesn't work if a -> > precondition for FRAME_POINTER isn't true. ?Rabin's approach at least +> > precondition for FRAME_POINTER isn't true. Rabin's approach at least > > generates a warning. > > If a precondition for FRAME_POINTER isn't true, we should not force it @@ -27,3 +27,50 @@ On Mon, Nov 08, 2010 at 10:42:57AM +0000, Catalin Marinas wrote: > keep the changes within the arch/arm tree. OK, new patch below. + +>From ce3856933234b0976068be8bdc46340dcf31ef6f Mon Sep 17 00:00:00 2001 +From: Rabin Vincent <rabin@rab.in> +Date: Sat, 6 Nov 2010 23:03:53 +0530 +Subject: [PATCHv2] ARM: ftrace: enable function graph tracer + +Add the options to enable the function graph tracer on ARM. Function +graph tracer support requires frame pointers, so exclude Thumb-2 and +also make sure FRAME_POINTER gets enabled when FUNCTION_GRAPH_TRACER is +used, since FUNCTION_TRACER doesn't "select FRAME_POINTER" when +ARM_UNWIND is used. Therefore, with GCC 4.4.0+, you get plain function +tracing without frame pointers, but you'll need them if you want +function graph tracing. + +Signed-off-by: Rabin Vincent <rabin@rab.in> +--- + arch/arm/Kconfig | 1 + + arch/arm/Kconfig.debug | 2 +- + 2 files changed, 2 insertions(+), 1 deletions(-) + +diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig +index a19a526..c5e96ff 100644 +--- a/arch/arm/Kconfig ++++ b/arch/arm/Kconfig +@@ -14,6 +14,7 @@ config ARM + select HAVE_FUNCTION_TRACER if (!XIP_KERNEL) + select HAVE_FTRACE_MCOUNT_RECORD if (!XIP_KERNEL) + select HAVE_DYNAMIC_FTRACE if (!XIP_KERNEL) ++ select HAVE_FUNCTION_GRAPH_TRACER if (!THUMB2_KERNEL) + select HAVE_GENERIC_DMA_COHERENT + select HAVE_KERNEL_GZIP + select HAVE_KERNEL_LZO +diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug +index 2fd0b99..eac62085 100644 +--- a/arch/arm/Kconfig.debug ++++ b/arch/arm/Kconfig.debug +@@ -23,7 +23,7 @@ config STRICT_DEVMEM + config FRAME_POINTER + bool + depends on !THUMB2_KERNEL +- default y if !ARM_UNWIND ++ default y if !ARM_UNWIND || FUNCTION_GRAPH_TRACER + help + If you say N here, the resulting kernel will be slightly smaller and + faster. However, if neither FRAME_POINTER nor ARM_UNWIND are enabled, +-- +1.7.2.3 diff --git a/a/content_digest b/N1/content_digest index e9282ad..a44abe0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,30 +3,36 @@ "ref\0AANLkTin8UO9ixVep0jKK8H5roWEVRDJW4khUpT2TpPs+@mail.gmail.com\0" "ref\020101108091858.GP16938@pengutronix.de\0" "ref\0AANLkTinmSn1fqKv8sCCP8d0-_0HsLrhtorXvHCovOYve@mail.gmail.com\0" - "From\0rabin@rab.in (Rabin Vincent)\0" - "Subject\0[PATCH 6/6] ARM: ftrace: enable function graph tracer\0" + "From\0Rabin Vincent <rabin@rab.in>\0" + "Subject\0Re: [PATCH 6/6] ARM: ftrace: enable function graph tracer\0" "Date\0Tue, 9 Nov 2010 19:16:45 +0530\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Catalin Marinas <catalin.marinas@arm.com>\0" + "Cc\0Uwe Kleine-K\303\266nig <u.kleine-koenig@pengutronix.de>" + Frederic Weisbecker <fweisbec@gmail.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + Steven Rostedt <rostedt@goodmis.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + " Tim Bird <tim.bird@am.sony.com>\0" "\00:1\0" "b\0" "On Mon, Nov 08, 2010 at 10:42:57AM +0000, Catalin Marinas wrote:\n" - "> 2010/11/8 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:\n" + "> 2010/11/8 Uwe Kleine-K\303\266nig <u.kleine-koenig@pengutronix.de>:\n" "> > On Sat, Nov 06, 2010 at 07:06:28PM +0000, Catalin Marinas wrote:\n" "> >> On Saturday, November 6, 2010, Rabin Vincent <rabin@rab.in> wrote:\n" "> >> > --- a/kernel/trace/Kconfig\n" "> >> > +++ b/kernel/trace/Kconfig\n" "> >> > @@ -141,6 +141,7 @@ config FUNCTION_TRACER\n" "> >> >\n" - "> >> > ?config FUNCTION_GRAPH_TRACER\n" - "> >> > ?? ? ? ?bool \"Kernel Function Graph Tracer\"\n" - "> >> > + ? ? ? select FRAME_POINTER if ARM_UNWIND\n" + "> >> > \302\240config FUNCTION_GRAPH_TRACER\n" + "> >> > \302\240\302\240 \302\240 \302\240 \302\240bool \"Kernel Function Graph Tracer\"\n" + "> >> > + \302\240 \302\240 \302\240 select FRAME_POINTER if ARM_UNWIND\n" "> >>\n" "> >> Would it be better to modify FRAME_POINTER definition in the ARM\n" "> >> Kconfig so that it is enabled automatically when FUNCTION_GRAPH_TRACER\n" "> >> is enabled?\n" "> > I don't like that suggestion much because it hides the dependency.\n" "> > Moreover a \"default y if FUNCTION_GRAPH_TRACER\" doesn't work if a\n" - "> > precondition for FRAME_POINTER isn't true. ?Rabin's approach at least\n" + "> > precondition for FRAME_POINTER isn't true. \302\240Rabin's approach at least\n" "> > generates a warning.\n" "> \n" "> If a precondition for FRAME_POINTER isn't true, we should not force it\n" @@ -37,6 +43,53 @@ "> isn't a dependency issue here. It's more like a personal preference to\n" "> keep the changes within the arch/arm tree.\n" "\n" - OK, new patch below. + "OK, new patch below.\n" + "\n" + ">From ce3856933234b0976068be8bdc46340dcf31ef6f Mon Sep 17 00:00:00 2001\n" + "From: Rabin Vincent <rabin@rab.in>\n" + "Date: Sat, 6 Nov 2010 23:03:53 +0530\n" + "Subject: [PATCHv2] ARM: ftrace: enable function graph tracer\n" + "\n" + "Add the options to enable the function graph tracer on ARM. Function\n" + "graph tracer support requires frame pointers, so exclude Thumb-2 and\n" + "also make sure FRAME_POINTER gets enabled when FUNCTION_GRAPH_TRACER is\n" + "used, since FUNCTION_TRACER doesn't \"select FRAME_POINTER\" when\n" + "ARM_UNWIND is used. Therefore, with GCC 4.4.0+, you get plain function\n" + "tracing without frame pointers, but you'll need them if you want\n" + "function graph tracing.\n" + "\n" + "Signed-off-by: Rabin Vincent <rabin@rab.in>\n" + "---\n" + " arch/arm/Kconfig | 1 +\n" + " arch/arm/Kconfig.debug | 2 +-\n" + " 2 files changed, 2 insertions(+), 1 deletions(-)\n" + "\n" + "diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n" + "index a19a526..c5e96ff 100644\n" + "--- a/arch/arm/Kconfig\n" + "+++ b/arch/arm/Kconfig\n" + "@@ -14,6 +14,7 @@ config ARM\n" + " \tselect HAVE_FUNCTION_TRACER if (!XIP_KERNEL)\n" + " \tselect HAVE_FTRACE_MCOUNT_RECORD if (!XIP_KERNEL)\n" + " \tselect HAVE_DYNAMIC_FTRACE if (!XIP_KERNEL)\n" + "+\tselect HAVE_FUNCTION_GRAPH_TRACER if (!THUMB2_KERNEL)\n" + " \tselect HAVE_GENERIC_DMA_COHERENT\n" + " \tselect HAVE_KERNEL_GZIP\n" + " \tselect HAVE_KERNEL_LZO\n" + "diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug\n" + "index 2fd0b99..eac62085 100644\n" + "--- a/arch/arm/Kconfig.debug\n" + "+++ b/arch/arm/Kconfig.debug\n" + "@@ -23,7 +23,7 @@ config STRICT_DEVMEM\n" + " config FRAME_POINTER\n" + " \tbool\n" + " \tdepends on !THUMB2_KERNEL\n" + "-\tdefault y if !ARM_UNWIND\n" + "+\tdefault y if !ARM_UNWIND || FUNCTION_GRAPH_TRACER\n" + " \thelp\n" + " \t If you say N here, the resulting kernel will be slightly smaller and\n" + " \t faster. However, if neither FRAME_POINTER nor ARM_UNWIND are enabled,\n" + "-- \n" + 1.7.2.3 -5c97f23b72450da7b70a71c1864f5010758b8c533d5ff2a365a8a402979a6450 +49175c29c60cf7fcaa7f556cc0ab4e2ee8f2c01679361d3175793049e13db1d4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.