From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h
Date: Tue, 9 Nov 2010 22:01:18 +0200 [thread overview]
Message-ID: <20101109200118.GA13016@core2.telecom.by> (raw)
In-Reply-To: <AANLkTi=rTw+ByhdGc9prjwvqt_TT=NmOYzEjns1LffLC@mail.gmail.com>
On Tue, Nov 09, 2010 at 10:49:19AM -0800, Linus Torvalds wrote:
> On Tue, Nov 9, 2010 at 10:43 AM, Joe Perches <joe@perches.com> wrote:
> >
> > diff from V1 - Don't add pr_<level>_once macros
> >
> > include/linux/kernel.h | 244 +--------------------------------------
> > include/linux/logging.h | 295 +++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 296 insertions(+), 243 deletions(-)
> > create mode 100644 include/linux/logging.h
>
> So where do the extra 53 lines come from now?
>
> This still is clearly not just code movement, and it's impossible for
> me to see what actually changed. Something must have.
Why linux_banner is moved?
Why linux_proc_banner is moved?
Why header is not named printk.h?
Why random stuff like log_buf_kexec_setup() and hexdump is moved?
next prev parent reply other threads:[~2010-11-09 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 5:38 [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h Joe Perches
2010-11-09 18:23 ` Linus Torvalds
2010-11-09 18:43 ` [PATCH V2] " Joe Perches
2010-11-09 18:49 ` Linus Torvalds
2010-11-09 19:17 ` Joe Perches
2010-11-09 21:00 ` Ted Ts'o
2010-11-09 21:08 ` Joe Perches
2010-11-09 23:52 ` [PATCH V3] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
2010-11-09 20:01 ` Alexey Dobriyan [this message]
2010-11-09 20:10 ` [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h Joe Perches
2010-11-09 20:30 ` Joe Perches
2010-11-15 18:04 ` [PATCH V4] include/linux/kernel.h: Move logging bits to include/linux/printk.h Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109200118.GA13016@core2.telecom.by \
--to=adobriyan@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.