From: Kees Cook <kees.cook@canonical.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup
Date: Tue, 9 Nov 2010 12:48:57 -0800 [thread overview]
Message-ID: <20101109204857.GT5876@outflux.net> (raw)
In-Reply-To: <AANLkTik3C01Pvv_RvgKXctjKjw=XS4AeEN94ADZtw+sW@mail.gmail.com>
Hi Pekka,
On Tue, Nov 09, 2010 at 10:28:16PM +0200, Pekka Enberg wrote:
> So why can't we do patch 2/4 XD_DISABLE clearing in
> early_init_intel()?
Because it's too late, unfortunately. I went around a few times about this
with Peter Anvin, and ultimately he agreed that it needed to go in
verify_cpu() for now.
> Why do we want to call verify_cpu() from
> arch/x86/kernel/head_32.S and not from
> arch/x86/boot/compressed/head_32.S like we do on 64-bit?
Because the longmode/SSE tests being performed in verify_cpu() need to
happen that early for 64bit. Instead of including it in two places for
32bit, we can just include it once in arch/x86/kernel/head_32.S.
-Kees
--
Kees Cook
Ubuntu Security Team
next prev parent reply other threads:[~2010-11-09 20:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 18:11 [Security] [PATCH v3 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-11-09 18:14 ` [PATCH 1/4] x86: rename verify_cpu_64.S to verify_cpu.S Kees Cook
2010-11-09 18:46 ` Pekka Enberg
2010-11-09 19:00 ` Kees Cook
2010-11-09 19:59 ` Pekka Enberg
2010-11-09 19:02 ` Kees Cook
2010-11-09 19:11 ` Pekka Enberg
2010-11-09 18:15 ` [PATCH 2/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-11-10 16:11 ` Andi Kleen
2010-11-10 16:47 ` Kees Cook
2010-11-10 17:42 ` Andi Kleen
2010-11-10 18:15 ` Kees Cook
2010-11-09 18:15 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
2010-11-09 19:09 ` Pekka Enberg
2010-11-09 19:19 ` Kees Cook
2010-11-09 19:46 ` Pekka Enberg
2010-11-09 19:56 ` Kees Cook
2010-11-09 20:28 ` Pekka Enberg
2010-11-09 20:48 ` Kees Cook [this message]
2010-11-09 20:50 ` Pekka Enberg
2010-11-09 18:15 ` [PATCH 4/4] x86: only CPU features determine NX capabilities Kees Cook
2010-11-09 18:31 ` [Security] [PATCH v3 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Alan Cox
2010-11-09 18:56 ` Kees Cook
2010-11-09 22:50 ` Alan Cox
2010-11-09 23:53 ` Kees Cook
2010-11-10 0:21 ` Alan Cox
2010-11-10 0:43 ` Kees Cook
2010-11-10 1:10 ` Kees Cook
2010-11-10 11:11 ` Alan Cox
2010-11-10 11:15 ` Ingo Molnar
2010-11-11 15:15 ` Rogier Wolff
-- strict thread matches above, loose matches on Subject: below --
2010-11-10 18:35 [Security] [PATCH v5 " Kees Cook
2010-11-10 18:35 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
2010-11-14 6:33 ` Yinghai Lu
2010-11-09 22:17 [Security] [PATCH v4 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-11-09 22:18 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
2010-06-19 5:50 [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-06-19 5:52 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109204857.GT5876@outflux.net \
--to=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.