All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: dirk.brandewie@gmail.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/6] serial/ce4100: Add PCI UART support for the ce4100
Date: Tue, 9 Nov 2010 13:14:18 -0800	[thread overview]
Message-ID: <20101109211418.GA15802@kroah.com> (raw)
In-Reply-To: <654d0e8f80dd959fd9c871ad1644126d58b2445b.1289331834.git.dirk.brandewie@gmail.com>

On Tue, Nov 09, 2010 at 12:08:06PM -0800, dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.brandewie@gmail.com>
> 
> This patch adds support for the PCI UART on the ce4100.
> 
> Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
> CC: linux-serial@vger.kernel.org
> ---
>  drivers/serial/8250_pci.c |   35 +++++++++++++++++++++++++++++++++++
>  include/linux/pci_ids.h   |    1 +

You did read the top of pci_ids.h right?  Why are you adding new ids
that are only used by one file?

Please don't do that.

thanks,

greg k-h

  reply	other threads:[~2010-11-09 21:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 20:08 [PATCH 0/6] Add support for the Intel CE4100 dirk.brandewie
2010-11-09 20:08 ` [PATCH 1/6] x86: Add CE4100 platform support dirk.brandewie
2010-11-09 20:08 ` [PATCH 2/6] ce4100: add PCI register emulation for CE4100 dirk.brandewie
2010-11-11 11:51   ` Thomas Gleixner
2010-11-09 20:08 ` [PATCH 3/6] serial/ce4100: Add PCI UART support for the ce4100 dirk.brandewie
2010-11-09 21:14   ` Greg KH [this message]
2010-11-09 21:54     ` Dirk Brandewie
2010-11-30 21:45     ` [PATCH] " dirk.brandewie
2010-11-17 15:35   ` dirk.brandewie
2010-11-09 20:08 ` [PATCH 4/6] ce4100: Add errata fixes for UART on CE4100 dirk.brandewie
2010-11-11 11:34   ` Thomas Gleixner
2010-11-11 11:52     ` Dirk Brandewie
2010-11-11 11:47       ` Thomas Gleixner
2010-11-11 12:10         ` Dirk Brandewie
2010-11-11 12:06           ` Thomas Gleixner
2010-11-22 14:28   ` [PATCH] " dirk.brandewie
2010-12-06 15:00     ` [tip:x86/platform] " tip-bot for Dirk Brandewie
2010-11-09 20:08 ` [PATCH 5/6] x86: ce4100: Add reboot_fixup() for CE4100 dirk.brandewie
2010-11-09 20:08 ` [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to EHCI driver dirk.brandewie
2010-11-09 22:01   ` Dirk Brandewie
2010-11-10  2:36     ` Alan Stern
2010-11-10 10:51       ` Sergei Shtylyov
2010-11-16 21:46         ` Greg KH
2010-11-16 23:24           ` Dirk Brandewie
2010-11-17 15:43   ` [PATCH] " dirk.brandewie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109211418.GA15802@kroah.com \
    --to=greg@kroah.com \
    --cc=dirk.brandewie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.