All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fs, sysfs: Change sysfs_pathname function prototype.
Date: Tue, 9 Nov 2010 14:44:50 -0800	[thread overview]
Message-ID: <20101109224450.GB21992@kroah.com> (raw)
In-Reply-To: <AANLkTikDXtLrfjYkQrkGi44qi0cpp-C+Lxr5j1UkFd2G@mail.gmail.com>

On Sun, Oct 31, 2010 at 05:48:36PM +0600, Rakib Mullick wrote:
> Make sysfs_pathname inline, we we're hit by the following warning:
> 
> 
> fs/sysfs/dir.c:410: warning: ‘sysfs_pathname’ defined but not used
> 
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail>
> ---
> 
> --- linus-36/fs/sysfs/dir.c	2010-10-21 02:30:22.000000000 +0600
> +++ rakib-36/fs/sysfs/dir.c	2010-10-31 17:34:46.000000000 +0600
> @@ -407,7 +407,7 @@ int __sysfs_add_one(struct sysfs_addrm_c
>   *
>   *	XXX: does no error checking on @path size
>   */
> -static char *sysfs_pathname(struct sysfs_dirent *sd, char *path)
> +static inline char *sysfs_pathname(struct sysfs_dirent *sd, char *path)

If it's really not used then why would marking it inline help out any?
Shouldn't we just delete the function instead?

thanks,

greg k-h

  reply	other threads:[~2010-11-09 22:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-31 11:48 [PATCH] fs, sysfs: Change sysfs_pathname function prototype Rakib Mullick
2010-11-09 22:44 ` Greg KH [this message]
2010-11-10  4:53   ` Rakib Mullick
2010-11-10 18:39     ` Greg KH
2010-11-11  6:11       ` Rakib Mullick
2010-11-11 12:19         ` Greg KH
2010-11-11 16:36           ` Rakib Mullick
2010-11-13 13:35             ` Rakib Mullick
2010-11-13 14:45               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109224450.GB21992@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakib.mullick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.