All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Johan Meiring <johanmeiring@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] Staging: wlan-ng: fix coding style issues in prism2mib.c
Date: Tue, 9 Nov 2010 16:36:50 -0800	[thread overview]
Message-ID: <20101110003650.GA15206@kroah.com> (raw)
In-Reply-To: <1289060607-13840-1-git-send-email-johanmeiring@gmail.com>

On Sat, Nov 06, 2010 at 06:23:27PM +0200, Johan Meiring wrote:
> This is a patch to the prism2mib.c file that fixes various coding style
> issues that were found by the checkpatch.pl tool
> 
> Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mib.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index d3a06fa..c1276fd 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -136,7 +136,8 @@ static int prism2mib_fragmentationthreshold(struct mibrec *mib,
>  					    int isget,
>  					    wlandevice_t *wlandev,
>  					    hfa384x_t *hw,
> -					    struct p80211msg_dot11req_mibset *msg,
> +					    struct p80211msg_dot11req_mibset
> +						*msg,

That's really not much better, so let's just leave the original code.

thanks,

greg k-h

      reply	other threads:[~2010-11-10  0:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 16:23 [PATCH 4/6] Staging: wlan-ng: fix coding style issues in prism2mib.c Johan Meiring
2010-11-10  0:36 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110003650.GA15206@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=johanmeiring@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.