From: Paul Mundt <lethal@linux-sh.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Thomas Winischhofer <thomas@winischhofer.net>
Subject: Re: [PATCHv2] sisfb: limit POST memory test according to PCI resource length
Date: Wed, 10 Nov 2010 11:27:02 +0000 [thread overview]
Message-ID: <20101110112702.GB1475@linux-sh.org> (raw)
In-Reply-To: <1289387059-31760-1-git-send-email-aaro.koskinen@iki.fi>
On Wed, Nov 10, 2010 at 01:04:19PM +0200, Aaro Koskinen wrote:
> If the POST memory test fails, the driver may access illegal
> memory areas. Instead of hard coding the maximum size, set it
> according to the PCI resource length (an additional check is needed in
> sisfb_post_map_vram() to ensure it's big enough). DRAM sizing will later
> adjust video_size to the correct value.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> ---
>
> v2: Add a check to sisfb_post_map_vram().
>
Queued for .37, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Thomas Winischhofer <thomas@winischhofer.net>
Subject: Re: [PATCHv2] sisfb: limit POST memory test according to PCI resource length
Date: Wed, 10 Nov 2010 20:27:02 +0900 [thread overview]
Message-ID: <20101110112702.GB1475@linux-sh.org> (raw)
In-Reply-To: <1289387059-31760-1-git-send-email-aaro.koskinen@iki.fi>
On Wed, Nov 10, 2010 at 01:04:19PM +0200, Aaro Koskinen wrote:
> If the POST memory test fails, the driver may access illegal
> memory areas. Instead of hard coding the maximum size, set it
> according to the PCI resource length (an additional check is needed in
> sisfb_post_map_vram() to ensure it's big enough). DRAM sizing will later
> adjust video_size to the correct value.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> ---
>
> v2: Add a check to sisfb_post_map_vram().
>
Queued for .37, thanks.
next prev parent reply other threads:[~2010-11-10 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:04 [PATCHv2] sisfb: limit POST memory test according to PCI resource length Aaro Koskinen
2010-11-10 11:04 ` Aaro Koskinen
2010-11-10 11:27 ` Paul Mundt [this message]
2010-11-10 11:27 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110112702.GB1475@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=aaro.koskinen@iki.fi \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.