[Ocfs2-devel] [PATCH 4/5] ocfs2: Add ocfs2_trace.h.

[Joel Becker <Joel.Becker@oracle.com>]

On Wed, Nov 10, 2010 at 10:33:37PM +0800, Tao Ma wrote:
> Joel Becker wrote:
> Yeah, sorry, I forgot to add a "From:Wengang Wang
> <wen.gang.wang@oracle.com>" in my guilt.
> That way, it will generate the commit with Author of wengang wang
> automatically. Since this patch only
> includes about 19 lines of change, and I changed about 5-6 lines,
> the author should be him.

	No worries.  Sounds correct.

> As for the 2nd one, his original patch has this diffstat:
> fs/ocfs2/alloc.c | 47 +++++-----
> include/trace/events/ocfs2.h | 202
> ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 224 insertions(+), 25 deletions(-)
> 
> My patch has
> 
> fs/ocfs2/alloc.c       |  165 +++++++++--------
> fs/ocfs2/ocfs2_trace.h |  485 ++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 573 insertions(+), 77 deletions(-)
> 
> So I guess the author should be me(What's more, I have changed some
> of his modifications also.)?
> Or I should leave his patch there with his sob, while adding a new
> patch of mine?

	You are clearly the author.  You should credit him in the commit
text, and add him as a Cc: line at the bottom, but it is now your work.

Joel

-- 

"A narcissist is someone better looking than you are."  
         - Gore Vidal

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127