All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@kernel.dk>
To: Salman Qazi <sqazi@google.com>
Cc: Nick Piggin <npiggin@kernel.dk>,
	paulmck@us.ibm.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	adurbin@google.com
Subject: Re: [PATCH] Fixed a mismatch between the users of radix_tree and the implementation.
Date: Thu, 11 Nov 2010 11:29:57 +1100	[thread overview]
Message-ID: <20101111002957.GB3477@amd> (raw)
In-Reply-To: <AANLkTi=hFPFHyZC3tpkF4mOgUYa+B_eVPdeKq-BwVaB9@mail.gmail.com>

On Wed, Nov 10, 2010 at 11:16:21AM -0800, Salman Qazi wrote:
> On Mon, Aug 30, 2010 at 4:27 PM, Salman Qazi <sqazi@google.com> wrote:
> > On Tue, Aug 17, 2010 at 2:28 PM, Salman Qazi <sqazi@google.com> wrote:
> >> > -               if (unlikely(page == RADIX_TREE_RETRY))
> >> > +               if (radix_tree_deref_retry(page))
> >> >                        goto restart;
> >> >
> >> >                if (!page_cache_get_speculative(page))
> >> >
> >>
> >> I just verified that your patch fixes the issue.  Thanks for doing this.
> >
> > Are we going to proceed with this?
> >
> 
> 
> This bug is still unresolved.  Can we please follow this patch through
> to conclusion?

Yep, I'm about 30 minutes ahead of you (if you ignore the couple of
months I am behind).

I forgot to add you to cc, sorry -- patch just went to lkml and Linus.

Thanks for following up.

Thanks,
Nick

      reply	other threads:[~2010-11-11  0:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13  7:15 [PATCH] Fixed a mismatch between the users of radix_tree and the implementation Salman Qazi
2010-08-13  7:20 ` Salman Qazi
2010-08-16 11:25   ` Peter Zijlstra
2010-08-16 18:30     ` Salman Qazi
2010-08-16 19:33       ` Peter Zijlstra
     [not found]         ` <AANLkTindpUo5tPiXVp6wXjOAqczrJvYegrOMBqSjr4_t@mail.gmail.com>
2010-08-16 21:05           ` Salman Qazi
2010-08-16 21:06           ` Peter Zijlstra
2010-08-17  4:35             ` Salman Qazi
2010-08-17  4:45               ` Salman Qazi
2010-08-17  8:42                 ` Peter Zijlstra
2010-08-17 15:23       ` Nick Piggin
2010-08-17 15:48         ` Peter Zijlstra
2010-08-17 19:49           ` Salman Qazi
2010-08-17 21:28         ` Salman Qazi
2010-08-30 23:27           ` Salman Qazi
2010-11-10 19:16             ` Salman Qazi
2010-11-11  0:29               ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101111002957.GB3477@amd \
    --to=npiggin@kernel.dk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adurbin@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@us.ibm.com \
    --cc=sqazi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.