From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH 1/3] qemu-kvm: Ioctl for in-kernel mask support
Date: Thu, 11 Nov 2010 14:20:41 +0800
Message-ID: <201011111420.41867.sheng@linux.intel.com>
References: <1288851501-4180-1-git-send-email-sheng@linux.intel.com> <201011051059.23872.sheng@linux.intel.com> <20101105085247.GG3464@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga14.intel.com ([143.182.124.37]:62849 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755505Ab0KKGUl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 11 Nov 2010 01:20:41 -0500
In-Reply-To: <20101105085247.GG3464@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Friday 05 November 2010 16:52:47 Michael S. Tsirkin wrote:
> On Fri, Nov 05, 2010 at 10:59:23AM +0800, Sheng Yang wrote:
> > > We are trying to move away from using ifdefs. Stub these out instead?
> > 
> > Example?
> 
> 37859f054986fab6b4094cd5950266ae56a6ca6a and
> 889e30cc18e21f2091b77267dca8096d7dd34f8b that depends on it.

Gave it a try, but the parameter of the function depends on certain version of KVM 
header file which still require #ifdef...

I think we can leave it a bit later.

--
regards
Yang, Sheng

> 
> > --
> > regards
> > Yang, Sheng