All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, nm@ti.com,
	Paul Walmsley <paul@pwsan.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions
Date: Thu, 11 Nov 2010 08:35:47 -0800	[thread overview]
Message-ID: <20101111163547.GO9264@atomide.com> (raw)
In-Reply-To: <1287526956-21853-4-git-send-email-b-cousson@ti.com>

* Benoit Cousson <b-cousson@ti.com> [101019 15:14]:
> --- a/arch/arm/mach-omap2/mux.h
> +++ b/arch/arm/mach-omap2/mux.h
> +
> +/**
> + * struct mux_partition - contain partition related information
> + * @name: name of the current partition
> + * @flags: flags specific to this partition
> + * @phys: physical address
> + * @size: partition size
> + * @base: virtual address after ioremap
> + * @muxmodes: list of nodes that belong to a partition
> + * @node: list node for the partitions linked list
> + */
> +struct omap_mux_partition {
> +	const char		*name;
> +	u32			flags;
> +	u32			phys;
> +	u32			size;
> +	void __iomem		*base;
> +	struct list_head	muxmodes;
> +	struct list_head	node;
> +};

With the omap_mux_parition..
  
>  /**
>   * struct omap_mux - data for omap mux register offset and it's value
>   * @reg_offset:	mux register offset from the mux base
>   * @gpio:	GPIO number
> + * @id:		Partition identifier
>   * @muxnames:	available signal modes for a ball
>   */
>  struct omap_mux {
> @@ -82,6 +114,7 @@ struct omap_mux {
>  	char	*muxnames[OMAP_MUX_NR_MODES];
>  #ifdef CONFIG_DEBUG_FS
>  	char	*balls[OMAP_MUX_NR_SIDES];
> +	struct omap_mux_partition *partition;
>  #endif
>  #endif
>  };
> @@ -89,6 +122,7 @@ struct omap_mux {
>  /**
>   * struct omap_ball - data for balls on omap package
>   * @reg_offset:	mux register offset from the mux base
> + * @id:		Partition identifier
>   * @balls:	available balls on the package
>   */
>  struct omap_ball {
> @@ -100,6 +134,7 @@ struct omap_ball {
>   * struct omap_board_mux - data for initializing mux registers
>   * @reg_offset:	mux register offset from the mux base
>   * @mux_value:	desired mux value to set
> + * @id:		Partition identifier
>   */
>  struct omap_board_mux {
>  	u16	reg_offset;

..I think the above changes are no longer needed.

Regards,

Tony

  reply	other threads:[~2010-11-11 16:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 22:22 [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support Benoit Cousson
2010-10-19 22:22 ` [RFC v2 1/7] OMAP: mux: Replace printk with pr_xxx macros Benoit Cousson
2010-10-19 22:22 ` [RFC v2 2/7] OMAP3: RX-51: Temporary disable dynamic mux change for eMMC Benoit Cousson
2010-10-19 22:22 ` [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions Benoit Cousson
2010-11-11 16:35   ` Tony Lindgren [this message]
2010-11-11 16:50     ` Cousson, Benoit
2010-11-11 16:55       ` Tony Lindgren
2010-10-19 22:22 ` [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1 Benoit Cousson
2010-11-11  1:56   ` Tony Lindgren
2010-11-11 12:33     ` Cousson, Benoit
2010-11-11 16:38       ` Tony Lindgren
2010-11-11 16:55         ` Cousson, Benoit
2010-10-19 22:22 ` [RFC v2 5/7] OMAP4: mux: Select CBL package for SDP4430 with ES1 Benoit Cousson
2010-10-19 22:22 ` [RFC v2 6/7] OMAP4: mux: Add CBS package data for OMAP4430 ES2 Benoit Cousson
2010-10-19 22:22 ` [RFC v2 7/7] OMAP4: mux: Select CBS package for SDP4430 with ES2 Benoit Cousson
2010-10-19 23:06 ` [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support Tony Lindgren
2010-10-20 20:52   ` Cousson, Benoit
2010-11-11 16:53     ` Tony Lindgren
2010-11-11 17:02       ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101111163547.GO9264@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.