From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754889Ab0KKRbH (ORCPT ); Thu, 11 Nov 2010 12:31:07 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:33101 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754128Ab0KKRbF (ORCPT ); Thu, 11 Nov 2010 12:31:05 -0500 Date: Thu, 11 Nov 2010 18:30:48 +0100 From: Ingo Molnar To: Borislav Petkov Cc: Peter Zijlstra , Ben Gamari , "acme@infradead.org" , "fweisbec@gmail.com" , "rostedt@goodmis.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 03/20] x86, mce: Add persistent MCE event Message-ID: <20101111173048.GA5769@elte.hu> References: <1288885016-18295-1-git-send-email-bp@amd64.org> <1288885016-18295-4-git-send-email-bp@amd64.org> <87lj50vq0s.fsf@gmail.com> <20101110222157.GA23945@elte.hu> <20101111061725.GA19321@aftab> <20101111085825.GB18789@elte.hu> <20101111133442.GA21803@aftab> <1289489930.2084.138.camel@laptop> <20101111155559.GD21803@aftab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101111155559.GD21803@aftab> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Thu, Nov 11, 2010 at 10:38:50AM -0500, Peter Zijlstra wrote: > > On Thu, 2010-11-11 at 14:34 +0100, Borislav Petkov wrote: > > > 3) enable the persistent event and stash its fd in some /sysfs member > > > which the RAS daemon reads out and mmaps. This last one actually sounds > > > pretty neat. > > > > Right, stashing the thing in sysfs, which you can open()+mmap() seems > > the best way. Not sure you want to make it a RAS specific place, maybe a > > generic persistent buffer place. > > > > You'll get multiple files anyway, one per cpu, so maybe something like: > > > > /sysfs/persistent_buffer/ras[0..n] > > Yeah, or even integrate it even further into the events hierarchy like > this: > > /sys/.../cpu/events/mce -> this is the trace_mce_record tracepoint > /sys/.../cpu/events/mce_pers -> persistent buffer fd > > or an additional level further down > > /sys/.../cpu/events/mce/persistent/... > > or whatever. > > Generally I don't care too much where we put it at the end. It should be in a nice logical place though :-) Thanks, Ingo