Re: [PATCH 0/8] PCI capability and device assignment improvements

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Nov 11, 2010 at 07:54:49PM -0700, Alex Williamson wrote:
> This series attempts to clean up capability support between common
> code and device assignment.  In doing so, we can move existing MSI &
> MSI-X capabilities to offsets matching real hardware, and further
> enable more capabilities to be exposed.

Very good cleanup overall. Some further suggestions posted.
Thanks!


> The last patch is only for RFC, I'd like some input on what we should
> pass directly and where we should only provide read-only/emulated
> access.  Patches 1-7 are submitted for commit.  Thanks,
> 
> Alex
> 
> ---
> 
> Alex Williamson (8):
>       device-assignment: pass through and stub more PCI caps
>       pci: Pass ID for capability read/write handlers
>       device-assignment: Move PCI capabilities to match physical hardware
>       pci: Remove cap.length, cap.start, cap.supported
>       pci: Replace used bitmap with capability byte map
>       device-assignment: Use PCI capabilities support
>       pci: Remove pci_enable_capability_support()
>       pci: pci_default_cap_write_config ignores wmask
> 
> 
>  hw/device-assignment.c |  273 ++++++++++++++++++++++++++++++++++++------------
>  hw/pci.c               |  103 +++++++-----------
>  hw/pci.h               |   25 ++--
>  3 files changed, 256 insertions(+), 145 deletions(-)