All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: fix compile warning in mm/init.c
Date: Fri, 12 Nov 2010 08:40:32 +0100	[thread overview]
Message-ID: <20101112074032.GF18358@pengutronix.de> (raw)
In-Reply-To: <1289542753-30185-1-git-send-email-gadiyar@ti.com>

On Fri, Nov 12, 2010 at 11:49:13AM +0530, Anand Gadiyar wrote:
> Commit 7c63984b86 (ARM: do not define VMALLOC_END relative to PAGE_OFFSET)
> changed VMALLOC_END to be an explicit value. Before this, it was
> relative to PAGE_OFFSET and therefore automatically upgraded to
> unsigned long as PAGE_OFFSET was an unsigned long. This introduced
> the following build warning. Fix this.
> 
>   CC      arch/arm/mm/init.o
> arch/arm/mm/init.c: In function 'mem_init':
> arch/arm/mm/init.c:606: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> ---
>  arch/arm/mm/init.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: ehci/arch/arm/mm/init.c
> ===================================================================
> --- ehci.orig/arch/arm/mm/init.c
> +++ ehci/arch/arm/mm/init.c
> @@ -593,7 +593,7 @@ void __init mem_init(void)
>  #ifdef CONFIG_MMU
>  			MLM(CONSISTENT_BASE, CONSISTENT_END),
>  #endif
> -			MLM(VMALLOC_START, VMALLOC_END),
> +			MLM(VMALLOC_START, (unsigned long)VMALLOC_END),
I wonder if this is the only place where this is a problem.  Maybe it's
better to make the defined value of all VMALLOC_END an unsigned long as
some already are?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-11-12  7:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  6:19 ARM: fix compile warning in mm/init.c Anand Gadiyar
2010-11-12  7:40 ` Uwe Kleine-König [this message]
2010-11-12  8:22   ` Kyungmin Park
2010-11-12  8:36 ` Russell King - ARM Linux
2010-11-12  8:49   ` Anand Gadiyar
2010-11-12  8:51     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101112074032.GF18358@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.