diff for duplicates of <20101112120705.GF27763@nokia.com> diff --git a/a/1.txt b/N1/1.txt index 752d448..bfb5037 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On Fri, Nov 12, 2010 at 12:47:15PM +0100, ext Samreen wrote: > int r = 0; > > str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); -> + if (str = NULL) +> + if (str == NULL) > + return -EINVAL; > strcpy(str, def_mode); @@ -22,3 +22,7 @@ While you're at it you could change the code to use kstrdup(). -- Ville Syrjälä +-- +To unsubscribe from this list: send the line "unsubscribe linux-omap" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index da450cb..7dd7554 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01289562435-8056-1-git-send-email-samreen@ti.com\0" "From\0Ville Syrj\303\244l\303\244 <ville.syrjala@nokia.com>\0" "Subject\0Re: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check\0" - "Date\0Fri, 12 Nov 2010 12:07:06 +0000\0" + "Date\0Fri, 12 Nov 2010 14:07:06 +0200\0" "To\0ext Samreen <samreen@ti.com>\0" "Cc\0Valkeinen Tomi (Nokia-MS/Helsinki) <Tomi.Valkeinen@nokia.com>" linux-omap@vger.kernel.org <linux-omap@vger.kernel.org> @@ -24,13 +24,17 @@ "> \tint r = 0;\n" "> \n" "> \tstr = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);\n" - "> +\tif (str = NULL)\n" + "> +\tif (str == NULL)\n" "> +\t\treturn -EINVAL;\n" "> \tstrcpy(str, def_mode);\n" "\n" "While you're at it you could change the code to use kstrdup().\n" "\n" "-- \n" - "Ville Syrj\303\244l\303\244" + "Ville Syrj\303\244l\303\244\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -832b91e6458403dd434c18f6c2a68002ef9ea7fdddaa0f4a547c9862c1a50807 +fbd691e2b54bd7f7cbd2aaf11f9ce82dd2c8cb342d15372651cefa42dfd9bf77
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.