From: "David Härdeman" <david@hardeman.nu>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Jarod Wilson <jarod@wilsonet.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion
Date: Fri, 12 Nov 2010 15:08:58 +0100 [thread overview]
Message-ID: <20101112140858.GA15203@hardeman.nu> (raw)
In-Reply-To: <4CDD3982.8070804@infradead.org>
On Fri, Nov 12, 2010 at 10:56:34AM -0200, Mauro Carvalho Chehab wrote:
>Em 12-11-2010 10:12, David Härdeman escreveu:
>> Shouldn't platform_data be const? And you'll break the refcounting
>> done in rc_allocate_device() and rc_free_device() /
>> rc_unregister_device(). Not to mention the silent bugs that may be
>> introduced if anyone modifies rc_allocate_device() without noticing
>> that one driver isn't using it.
>
>It will still be const. platform_data will pass a pointer to some struct.
>The value of the pointer won't change. I don't see why this would break
>refcounting, as what will happen is that the caller driver will call
>rc_allocate_device() and fill some fields there, instead of ir_kbd_i2c.
I think I've misunderstood what you've been proposing for ir_kbd_i2c.
That sounds like a good solution.
>I'm working on a patch for it right now.
Good, I'll just wait until the patches are available to comment :)
--
David Härdeman
next prev parent reply other threads:[~2010-11-12 14:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 20:17 [PATCH 0/6] rc-core: ir-core to rc-core conversion David Härdeman
2010-11-02 20:17 ` [PATCH 1/6] ir-core: convert drivers/media/video/cx88 to ir-core David Härdeman
2010-11-02 20:17 ` [PATCH 2/6] ir-core: remove remaining users of the ir-functions keyhandlers David Härdeman
2010-11-02 20:17 ` [PATCH 3/6] ir-core: more cleanups of ir-functions.c David Härdeman
2010-11-02 20:17 ` [PATCH 4/6] ir-core: merge and rename to rc-core David Härdeman
2010-11-02 20:18 ` [PATCH 5/6] ir-core: make struct rc_dev the primary interface David Härdeman
2010-11-02 20:18 ` [PATCH 6/6] rc-core: convert winbond-cir David Härdeman
2010-11-02 20:26 ` [PATCH 0/6] rc-core: ir-core to rc-core conversion Jarod Wilson
2010-11-10 1:50 ` Mauro Carvalho Chehab
2010-11-10 3:25 ` Jarod Wilson
2010-11-10 4:33 ` Mauro Carvalho Chehab
2010-11-10 9:28 ` David Härdeman
2010-11-10 9:24 ` David Härdeman
2010-11-10 12:49 ` Mauro Carvalho Chehab
2010-11-10 13:06 ` David Härdeman
2010-11-10 16:24 ` Mauro Carvalho Chehab
2010-11-10 22:01 ` David Härdeman
2010-11-11 13:54 ` Mauro Carvalho Chehab
2010-11-11 15:19 ` David Härdeman
2010-11-11 16:00 ` Mauro Carvalho Chehab
2010-11-11 20:35 ` David Härdeman
2010-11-11 23:40 ` Jarod Wilson
2010-11-12 4:00 ` Mauro Carvalho Chehab
2010-11-12 12:12 ` David Härdeman
2010-11-12 12:56 ` Mauro Carvalho Chehab
2010-11-12 14:08 ` David Härdeman [this message]
2010-11-12 14:15 ` Mauro Carvalho Chehab
2010-11-12 12:03 ` David Härdeman
2010-11-11 14:06 ` Mauro Carvalho Chehab
2010-11-09 10:27 ` David Härdeman
2010-11-09 10:34 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112140858.GA15203@hardeman.nu \
--to=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.