[Ocfs2-devel] [PATCH 1/2] Introduce ocfs2_recover_node

[Wengang Wang <wen.gang.wang@oracle.com>]

Hi,

On 10-11-12 13:22, Goldwyn Rodrigues wrote:
> Hi Wengang,
> 
> Thanks for the review.
> 
> On Thu, Nov 11, 2010 at 8:16 PM, Wengang Wang <wen.gang.wang@oracle.com> wrote:
> > On 10-11-11 19:01, Goldwyn Rodrigues wrote:
> >> ocfs2_recover_node is a new data structure to include all information required
> >> to recover one node. The structure is maintained as a list in the super block.
> >>
> >> ocfs2_recover_node replaces the recovery_map
> >>
> >> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
> >> - ? ? ? ? ? ? ? ? ? ? rm_quota[rm_quota_used++] = slot_num;
> >> + ? ? ? ? ? ? ? ? ? ? rm_quota[rm_quota_used++] = rn->rn_slot_num;
> >>
> >> - ? ? ? ? ? ? status = ocfs2_recover_node(osb, node_num, slot_num);
> >> + ? ? ? ? ? ? status = ocfs2_recover_one_node(rn);
> >> ?skip_recovery:
> >> ? ? ? ? ? ? ? if (!status) {
> >> - ? ? ? ? ? ? ? ? ? ? ocfs2_recovery_map_clear(osb, node_num);
> >> + ? ? ? ? ? ? ? ? ? ? ocfs2_recovery_map_clear(osb, rn);
> >
> > kfree with spinlocked here.
> >
> 
> What is the problem with that?

hm... seems no block in kfree() in current code.
please ignore that comment!

regards,
wengang.