From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Cam Macdonell <cam@cs.ualberta.ca>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: Cannot not unplug cold-plugged devices
Date: Sat, 13 Nov 2010 22:59:15 +0200 [thread overview]
Message-ID: <20101113205915.GA23361@redhat.com> (raw)
In-Reply-To: <20101112125030.GB27722@valinux.co.jp>
On Fri, Nov 12, 2010 at 09:50:30PM +0900, Isaku Yamahata wrote:
> On Fri, Nov 12, 2010 at 01:26:30PM +0200, Michael S. Tsirkin wrote:
> > No, I am just trying to understand why is hotplug event dangerous.
> > We still get it if we do device add before starting the VM, right?
>
> I'm not sure if it's safe to call enable/disable_device() and
> pm_update_sci() before starting VM.
> So I'd like to avoid to call them instead of making sure it.
> If someone else ensures its safety, I'm willing to eliminate the if clause.
Well I don't think it's dangerous.
I guess it makes sense for whatever is supplied on qemu command line
to not cause a hotplug event.
> --
> yamahata
next prev parent reply other threads:[~2010-11-13 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 6:29 [Qemu-devel] Cannot not unplug cold-plugged devices Cam Macdonell
2010-11-12 7:24 ` [Qemu-devel] " Isaku Yamahata
2010-11-12 9:18 ` Michael S. Tsirkin
2010-11-12 9:59 ` Isaku Yamahata
2010-11-12 11:26 ` Michael S. Tsirkin
2010-11-12 12:50 ` Isaku Yamahata
2010-11-13 20:59 ` Michael S. Tsirkin [this message]
2010-11-14 2:57 ` Isaku Yamahata
2010-11-14 10:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101113205915.GA23361@redhat.com \
--to=mst@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.