From: Greg KH <greg@kroah.com>
To: Maya Erez <merez@codeaurora.org>
Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mike Frysinger <vapier@gentoo.org>,
Cliff Cai <cliff.cai@analog.com>,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Fabien Chouteau <fabien.chouteau@barco.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] usb: Add streams support to epautoconf.
Date: Sun, 14 Nov 2010 10:29:15 -0800 [thread overview]
Message-ID: <20101114182915.GA20922@kroah.com> (raw)
In-Reply-To: <1289715812-29000-1-git-send-email-merez@codeaurora.org>
On Sun, Nov 14, 2010 at 08:23:20AM +0200, Maya Erez wrote:
> + /* Get the number of required streams from the EP companion
> + * descriptor and see if the EP matches it
> + */
Close, but this isn't the proper format for multi-line comments in the
kernel. Please fix this.
> + if (USB_ENDPOINT_XFER_BULK == type) {
Ick, no, don't do comparisons like this. The compiler will let you know
if you acidentally get it wrong with only one '=' character, don't do
things "backward" like this just to work around stupid compilers.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-14 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 6:23 [RFC/PATCH] usb: Add streams support to epautoconf Maya Erez
2010-11-14 18:29 ` Greg KH [this message]
2010-11-14 20:15 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2010-12-06 20:42 Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114182915.GA20922@kroah.com \
--to=greg@kroah.com \
--cc=cliff.cai@analog.com \
--cc=dbrownell@users.sourceforge.net \
--cc=fabien.chouteau@barco.com \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=merez@codeaurora.org \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.