From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Bruno Randolf <br1@einfach.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
randy.dunlap@oracle.com, peterz@infradead.org,
blp@cs.stanford.edu, linux-kernel@vger.kernel.org,
Lars_Ericsson@telia.com, kevin.granade@gmail.com,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function
Date: Mon, 15 Nov 2010 08:38:39 +0100 [thread overview]
Message-ID: <20101115083839.622b58af@stein> (raw)
In-Reply-To: <201011151110.46007.br1@einfach.org>
On Nov 15 Bruno Randolf wrote:
> On Sun November 14 2010 17:51:08 Stefan Richter wrote:
> > BTW, isn't "get" more usually used as a prefix for these kinds of
> > functions in kernel APIs? "get" as a suffix more often means "get
> > a reference" alias increase reference count rather than "get the
> > value".
>
> Umm. I don't know and honstly I don't care. I think the API ewma_* is
> consistent. If you have a good reason to change it please let me
> know, otherwise i'd just leave it like it is now.
It is not about consistency of the API in itself but about consistency
with the rest of the kernel. Cf. skb_get vs. get_unaligned and many
more. I for one immediately think of "something is having its
reference count incremented here" when I come across a something_get
when reading code.
I don't know of such a convention being documented anywhere. But for an
overkill of examples of "get" as prefix and suffix, grep for get_ and
_get( in include/. The same convention exists IME with "put" that
either writes a value or drops a reference.
Sorry for bringing this up so late but it is IMO not a trivial point.
--
Stefan Richter
-=====-==-=- =-== -====
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-11-15 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:47 [PATCH v6] Add generic exponentially weighted moving average (EWMA) function Bruno Randolf
2010-11-11 3:53 ` Andrew Morton
2010-11-11 3:59 ` Bruno Randolf
2010-11-11 4:02 ` Andrew Morton
2010-11-11 5:21 ` Bruno Randolf
2010-11-11 18:17 ` Stefan Richter
2010-11-12 1:44 ` Bruno Randolf
2010-11-14 5:07 ` KOSAKI Motohiro
2010-11-14 8:51 ` Stefan Richter
2010-11-15 2:10 ` Bruno Randolf
2010-11-15 7:38 ` Stefan Richter [this message]
2010-11-15 7:50 ` Bruno Randolf
2010-11-15 8:46 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2010-10-22 1:51 Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115083839.622b58af@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=Lars_Ericsson@telia.com \
--cc=akpm@linux-foundation.org \
--cc=blp@cs.stanford.edu \
--cc=br1@einfach.org \
--cc=kevin.granade@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.