From: Dan Carpenter <error27@gmail.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Mike Frysinger <vapier@gentoo.org>,
Feng Tang <feng.tang@intel.com>,
Tobias Klauser <tklauser@distanz.ch>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
qi.wang@intel.com, kok.howg.ewe@intel.com,
andrew.chih.howe.khor@intel.com
Subject: Re: [PATCH v3] EG20T: Update PCH_UART driver to 2.6.36
Date: Mon, 15 Nov 2010 15:40:56 +0300 [thread overview]
Message-ID: <20101115124055.GA29030@bicker> (raw)
In-Reply-To: <4CE126DB.4080500@dsn.okisemi.com>
On Mon, Nov 15, 2010 at 09:26:03PM +0900, Tomoya MORINAGA wrote:
> + spin_lock_irqsave(&port->lock, flags);
> +
> + uart_update_timeout(port, termios->c_cflag, baud);
> + rtn = pch_uart_hal_set_line(priv, baud, parity, bits, stb);
> + if (rtn)
You need a spin_unlock_irqrestore(&port->lock, flags); here.
> + return;
> +
> + /* Don't rewrite B0 */
> + if (tty_termios_baud_rate(termios))
> + tty_termios_encode_baud_rate(termios, baud, baud);
> +
> + spin_unlock_irqrestore(&port->lock, flags);
> +}
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-15 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 12:26 [PATCH v3] EG20T: Update PCH_UART driver to 2.6.36 Tomoya MORINAGA
2010-11-15 12:40 ` Dan Carpenter [this message]
2010-11-16 13:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115124055.GA29030@bicker \
--to=error27@gmail.com \
--cc=alan@linux.intel.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=ben-linux@fluff.org \
--cc=feng.tang@intel.com \
--cc=gregkh@suse.de \
--cc=kgene.kim@samsung.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tklauser@distanz.ch \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.