From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang2 Subject: [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel (V2) Date: Mon, 15 Nov 2010 14:58:23 +0100 Message-ID: <201011151458.24610.wei.wang2@amd.com> References: <201011151118.40873.wei.wang2@amd.com> <4CE1379702000078000223D4@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_AyT4MUoocXttQll" Return-path: In-Reply-To: <4CE1379702000078000223D4@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org --Boundary-00=_AyT4MUoocXttQll Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Jan Could this new version be a little more clear? Thanks, Wei Signed-off-by: Wei Wang On Monday 15 November 2010 13:37:27 Jan Beulich wrote: > >>> On 15.11.10 at 11:18, Wei Wang2 wrote: > > > >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 > > 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12 > > 17:10:31 2010 +0100 @@ -31,8 +31,8 @@ > > > > #define DMA_32BIT_MASK 0x00000000ffffffffULL > > > >-extern int amd_iommu_debug; > >-extern int amd_iommu_perdev_intremap; > >+extern bool_t amd_iommu_debug; > >+extern bool_t amd_iommu_perdev_intremap; > > > > #define AMD_IOMMU_DEBUG(fmt, args...) \ > > do \ > > This surely can't be complete: If you had a type mismatch between > declaration and definition, the defining code is clearly missing an > #include of the #define-ing header. > > Jan --Boundary-00=_AyT4MUoocXttQll Content-Type: text/x-diff; charset="iso-8859-1"; name="fix_pv_ops_32_v2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_pv_ops_32_v2.patch" Content-Description: fix_pv_ops_32_v2.patch diff -r 388c44a63613 xen/include/asm-x86/hvm/svm/amd-iommu-proto.h --- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Mon Nov 15 14:49:52 2010 +0100 @@ -30,9 +30,6 @@ &amd_iommu_head, list) #define DMA_32BIT_MASK 0x00000000ffffffffULL - -extern int amd_iommu_debug; -extern int amd_iommu_perdev_intremap; #define AMD_IOMMU_DEBUG(fmt, args...) \ do \ diff -r 388c44a63613 xen/include/xen/iommu.h --- a/xen/include/xen/iommu.h Wed Nov 10 14:56:06 2010 +0000 +++ b/xen/include/xen/iommu.h Mon Nov 15 14:49:52 2010 +0100 @@ -30,6 +30,8 @@ extern bool_t force_iommu, iommu_verbose extern bool_t force_iommu, iommu_verbose; extern bool_t iommu_workaround_bios_bug, iommu_passthrough; extern bool_t iommu_snoop, iommu_qinval, iommu_intremap; +extern bool_t amd_iommu_debug; +extern bool_t amd_iommu_perdev_intremap; extern struct rangeset *mmio_ro_ranges; --Boundary-00=_AyT4MUoocXttQll Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_AyT4MUoocXttQll--