All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org
Subject: Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts
Date: Mon, 15 Nov 2010 20:32:50 +0300	[thread overview]
Message-ID: <20101115173250.GA22104@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1289841916-3825-2-git-send-email-w.sang@pengutronix.de>

On Mon, Nov 15, 2010 at 06:25:16PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  arch/powerpc/boot/dts/pcm030.dts |    1 +
>  arch/powerpc/boot/dts/pcm032.dts |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
> index 8a4ec30..e7c36bc 100644
> --- a/arch/powerpc/boot/dts/pcm030.dts
> +++ b/arch/powerpc/boot/dts/pcm030.dts
> @@ -259,6 +259,7 @@
>  			eeprom@52 {
>  				compatible = "catalyst,24c32";
>  				reg = <0x52>;
> +				pagesize = <32>;

I think you'd better drop the pagesize property altogether, and
instead make the compatible string more specific (if needed at
all. are there any 'catalyst,24c32' chips with pagesize != 32?)

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2010-11-15 17:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 17:25 [PATCH 1/2] misc: at24: parse OF-data, too Wolfram Sang
2010-11-15 17:25 ` [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts Wolfram Sang
2010-11-15 17:32   ` Anton Vorontsov [this message]
2010-11-15 21:06     ` Mitch Bradley
2010-11-15 21:24       ` Anton Vorontsov
2010-11-15 21:58         ` Grant Likely
2010-11-15 21:58           ` Grant Likely
2010-11-15 22:17           ` Mitch Bradley
2010-11-15 22:30             ` David Gibson
2010-11-15 22:30               ` David Gibson
2010-11-15 22:11         ` Wolfram Sang
2010-11-15 22:11           ` Wolfram Sang
2010-11-16 21:45           ` Wolfram Sang
2010-11-16 21:45             ` Wolfram Sang
2010-11-16 22:03             ` Anton Vorontsov
2010-11-15 21:41 ` [PATCH 1/2] misc: at24: parse OF-data, too Grant Likely
2010-11-15 21:41   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101115173250.GA22104@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.