From: Oleg Nesterov <oleg@redhat.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, benh@kernel.crashing.org, cmetcalf@tilera.com,
davem@davemloft.net, deller@gmx.de, heiko.carstens@de.ibm.com,
hpa@zytor.com, jejb@parisc-linux.org, kyle@mcmartin.ca,
mingo@elte.hu, roland@redhat.com, schwidefsky@de.ibm.com,
tglx@linutronix.de, tony.luck@intel.com
Subject: Re: + exec_domain-establish-a-linux32-domain-on-config_compat-systems.patc h added to -mm tree
Date: Mon, 15 Nov 2010 20:19:55 +0100 [thread overview]
Message-ID: <20101115191955.GA17342@redhat.com> (raw)
In-Reply-To: <4CE182A2.1020606@caviumnetworks.com>
On 11/15, David Daney wrote:
>
> On 11/13/2010 09:17 AM, Oleg Nesterov wrote:
>>
>>> We can avoid the failed module loading overhead by building-in the
>>> linux32_exec_domain for systems that have CONFIG_COMPAT.
>>
>> Indeed. But at the same time this means it is not possible to use
>> personality-8.ko if the system has it.
>
> Well in the same way it is not possible to use personality-0.ko
> (PER_LINUX) because it is just as built-in.
Sure, but this was never possible. But your patch adds the obvious
user-visible change.
>> Don't get me wrong, I have no idea why anyone could want this module,
>> just I am a bit worried.
>
> If the personality is built-in, then I don't see how it makes any sense
> to attempt to override it with an externally supplied version. If you
> want set a domain for PER_LINUX32, don't configure you system to supply
> a default version.
Well, no need to convince me ;) To me, this request_module() doesn't
make any sense at all.
I won't argue against this change. Just I wanted to be sure this
issue is not overlooked.
Oleg.
prev parent reply other threads:[~2010-11-15 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 20:22 + exec_domain-establish-a-linux32-domain-on-config_compat-systems.patch added to -mm tree akpm
2010-11-13 17:17 ` + exec_domain-establish-a-linux32-domain-on-config_compat-systems.patc h " Oleg Nesterov
2010-11-15 18:57 ` David Daney
2010-11-15 19:19 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115191955.GA17342@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jejb@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.