All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohui Zheng <shaohui.zheng@intel.com>
To: "shaohui.zheng@linux.intel.com" <shaohui.zheng@linux.intel.com>,
	lethal@linux-sh.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [v2,5/8] NUMA Hotplug emulator
Date: Tue, 16 Nov 2010 13:05:07 +0800	[thread overview]
Message-ID: <20101116050507.GA21317@shaohui> (raw)
In-Reply-To: <A24AE1FFE7AEC5489F83450EE98351BF27D53BCC36@shsmsx502.ccr.corp.intel.com>

> 
> On Tue, Nov 16, 2010 at 12:13:30PM +0800, Shaohui Zheng wrote:
> > >This looks like an incredibly painful interface. How about scrapping all
> > >of this _emu() mess and just reworking the register_cpu() interface?
> > > Something like:
> > 
> > hi, Paul
> > 	I saw your reply on patchwork.kernel.org, but I did not find your email 
> > in my mailbox, you might forget to cc to me.
> > 
> Then fix your mailer. You are presently forcing Mail-Followup-To to the
> list, which in turn is dropping you from the cc on a group reply.

My mailer is mutt, and I did not configure "Mail-Follow-To", it should use the
default value. I add "set followup_to=no" to my ~/muttrc file now.

Hope it is got fixed, thanks you for your remind.

> 
> > 	I think that your register_cpu_node interface seems good, but this will 
> > remove the interface register_cpu. it is not the original purpose of the 
> > emulator, we want to emulate the oringal process, but we did not want to change
> > the old interface, that is a rule.
> > 
> Wait, what? How does my patch remove register_cpu()? It does no such
> thing, all it does is add a supplemental register_cpu_node() for you to
> call in to, without needing to carry any of the _emu() damage around. The
> old interface has not been modified in any way whatsoever.

I recheck your patch, It seems that I misunderstand it. with your function
register_cpu_node, we can call it in arch_cpu_probe, and then we need not the _emu()
any more. Our _emu() functions work, but it get thing complicated. :)

I will rework patch 4 and patch 5 with your suggestion, thanks.

-- 
Thanks & Regards,
Shaohui


  parent reply	other threads:[~2010-11-16  6:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  4:13 [v2,5/8] NUMA Hotplug emulator Shaohui Zheng
2010-11-16  5:47 ` Paul Mundt
     [not found]   ` <A24AE1FFE7AEC5489F83450EE98351BF27D53BCC36@shsmsx502.ccr.corp.intel.com>
2010-11-16  5:05     ` Shaohui Zheng [this message]
2010-11-16  7:04       ` Paul Mundt
2010-11-16  6:21         ` Shaohui Zheng
  -- strict thread matches above, loose matches on Subject: below --
2010-11-13  6:16 Shaohui Zheng
2010-11-15  6:58 ` Paul Mundt
2010-11-13  5:42 Shaohui Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116050507.GA21317@shaohui \
    --to=shaohui.zheng@intel.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohui.zheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.