From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH 01/13] Nested Virtualization: tools
Date: Tue, 16 Nov 2010 12:52:51 +0100
Message-ID: <201011161252.51591.Christoph.Egger@amd.com>
References: <201011121940.26108.Christoph.Egger@amd.com>
	<20101116113706.GA24801@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20101116113706.GA24801@whitby.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tuesday 16 November 2010 12:37:06 Tim Deegan wrote:
> Hi,
>
> At 18:40 +0000 on 12 Nov (1289587225), Christoph Egger wrote:
> > +#define SVM_FEATURE_NPT            0x00000001
> > +#define SVM_FEATURE_LBRV           0x00000002
> > +#define SVM_FEATURE_SVML           0x00000004
> > +#define SVM_FEATURE_NRIPS          0x00000008
> > +#define SVM_FEATURE_PAUSEFILTER    0x00000400
> > +
> > +        /* Only passthrough SVM features which are implemented */
> > +        edx = 0;
> > +        if (regs[3] & SVM_FEATURE_NPT)
> > +            edx |= SVM_FEATURE_NPT;
> > +        if (regs[3] & SVM_FEATURE_LBRV)
> > +            edx |= SVM_FEATURE_LBRV;
> > +        if (regs[3] & SVM_FEATURE_NRIPS)
> > +            edx |= SVM_FEATURE_NRIPS;
> > +        if (regs[3] & SVM_FEATURE_PAUSEFILTER)
> > +            edx |= SVM_FEATURE_PAUSEFILTER;
> > +
> > +        regs[3] = edx;
>
> Minor niggle - why isn't this just a single &= operation?

The l1 guest shouldn't see upcoming svm features yet.
They will be added here when support for them is implemented.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632