Re: [Qemu-devel] [PATCH] Introduce -accel command option.

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Nov 16, 2010 at 10:41:25AM -0600, Anthony Liguori wrote:
> On 11/16/2010 10:10 AM, Anthony PERARD wrote:
> >On Mon, 15 Nov 2010, Anthony Liguori wrote:
> >
> >   
> >>On 11/15/2010 09:45 AM, anthony.perard@citrix.com wrote:
> >>     
> >>>From: Anthony PERARD<anthony.perard@citrix.com>
> >>>
> >>>This option gives the ability to switch one "accelerator" like kvm, xen
> >>>or the default one tcg. We can specify more than one accelerator by
> >>>separate them by a comma. QEMU will try each one and use the first whose
> >>>works.
> >>>
> >>>So,
> >>>
> >>>-accel xen,kvm,tcg
> >>>
> >>>which would try Xen support first, then KVM and finaly tcg if none of
> >>>the other works.
> >>>
> >>>       
> >>Should use QemuOpts instead of parsing by hand.
> >>     
> >Ok for that.
> >
> >   
> >>I'd rather it be
> >>presented as a -machine option too with accel=xen:kvm:tcg to specify 
> >>order.
> >>     
> >This is not clear to me, did you mean that you prefer to have both
> >"-accel accels" and "-machine accel=accels" options?
> >   
> 
> Just -machine accel=accels.
> 
> Part of my rational is that accelerator is a machine property.  If you 
> do -M xenpv it ought to imply -machine accel=xen.

Surely, only if it is running on a Xen Dom0. If you use -M xenpv on a KVM
host, then -M xenpv should imply -machine accel=kvm (ie it would be using
xenner)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|