From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2.6.38] omap: McBSP: Fix potential memory leak in omap_mcbsp_remove
Date: Tue, 16 Nov 2010 13:31:15 -0800 [thread overview]
Message-ID: <20101116213114.GL9264@atomide.com> (raw)
In-Reply-To: <1288776263-6600-1-git-send-email-jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [101103 02:15]:
> Function omap_mcbsp_probe allocates struct omap_mcbsp *mcbsp but it is not
> freed in omap_mcbsp_remove. Fix this, remove unneeded structure cleanups
> and clk_disable calls since they are not needed here.
>
> This is not problem currently but becomes if the mcbsp driver is ever
> modularized.
Queuing this for 2.6.38 merge window.
Tony
prev parent reply other threads:[~2010-11-16 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 9:24 [PATCH 2.6.38] omap: McBSP: Fix potential memory leak in omap_mcbsp_remove Jarkko Nikula
2010-11-16 21:31 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116213114.GL9264@atomide.com \
--to=tony@atomide.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.