From: Nick Piggin <npiggin@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Nick Piggin <npiggin@kernel.dk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
petr@vandrovec.name
Subject: Re: [patch] fs: fix d_validate
Date: Wed, 17 Nov 2010 14:51:57 +1100 [thread overview]
Message-ID: <20101117035157.GB3302@amd> (raw)
In-Reply-To: <20101116162817.GA2168@lst.de>
On Tue, Nov 16, 2010 at 05:28:17PM +0100, Christoph Hellwig wrote:
> On Tue, Nov 16, 2010 at 09:25:33PM +1100, Nick Piggin wrote:
> > Right, I depreated it, making it an easy backport. Your next patch
> > and then removing it completely would be the next step.
>
> I don't see much of a point in keeping it. What your new version of
> d_validate does is exactly what the two only callers do as a fallback.
> Keeping it like that just means we search through d_subdirs another
> time when the lookup fails. No need to keep this beats around longer
> than nessecary.
It's really no problem to get my bug fixes merged, and keep the exported
symbol around on a deprecation schedule. It doesn't need to be held up by
Patches to rip the dir cache out of the filesystems.
next prev parent reply other threads:[~2010-11-17 3:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 6:23 [patch] fs: fix d_validate Nick Piggin
2010-11-16 6:24 ` [patch] kernel: get rid of *_ptr_validate Nick Piggin
2010-11-16 10:21 ` Christoph Hellwig
2010-11-16 10:20 ` [patch] fs: fix d_validate Christoph Hellwig
2010-11-16 10:25 ` Nick Piggin
2010-11-16 16:28 ` Christoph Hellwig
2010-11-17 3:51 ` Nick Piggin [this message]
2010-11-16 16:20 ` Linus Torvalds
2010-11-16 16:25 ` Christoph Hellwig
2010-11-17 3:49 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117035157.GB3302@amd \
--to=npiggin@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.