From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934222Ab0KQEbd (ORCPT ); Tue, 16 Nov 2010 23:31:33 -0500 Received: from mga11.intel.com ([192.55.52.93]:17287 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934136Ab0KQEba (ORCPT ); Tue, 16 Nov 2010 23:31:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,209,1288594800"; d="scan'208";a="627558216" Message-Id: <20101117042850.122583518@intel.com> User-Agent: quilt/0.48-1 Date: Wed, 17 Nov 2010 12:27:27 +0800 From: Wu Fengguang To: Andrew Morton CC: Jan Kara , Theodore Tso , Peter Zijlstra , Wu Fengguang CC: Christoph Hellwig CC: Dave Chinner CC: Chris Mason CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro Cc: linux-mm Cc: Cc: LKML Subject: [PATCH 07/13] writeback: show bdi write bandwidth in debugfs References: <20101117042720.033773013@intel.com> Content-Disposition: inline; filename=writeback-bandwidth-show.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a "BdiWriteBandwidth" entry (and indent others) in /debug/bdi/*/stats. btw increase digital field width to 10, for keeping the possibly huge BdiWritten number aligned at least for desktop systems. This will break user space tools if they are dumb enough to depend on the number of white spaces. CC: Theodore Ts'o CC: Jan Kara CC: Peter Zijlstra Signed-off-by: Wu Fengguang --- mm/backing-dev.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) --- linux-next.orig/mm/backing-dev.c 2010-11-15 12:52:34.000000000 +0800 +++ linux-next/mm/backing-dev.c 2010-11-15 12:52:44.000000000 +0800 @@ -87,21 +87,23 @@ static int bdi_debug_stats_show(struct s #define K(x) ((x) << (PAGE_SHIFT - 10)) seq_printf(m, - "BdiWriteback: %8lu kB\n" - "BdiReclaimable: %8lu kB\n" - "BdiDirtyThresh: %8lu kB\n" - "DirtyThresh: %8lu kB\n" - "BackgroundThresh: %8lu kB\n" - "BdiWritten: %8lu kB\n" - "b_dirty: %8lu\n" - "b_io: %8lu\n" - "b_more_io: %8lu\n" - "bdi_list: %8u\n" - "state: %8lx\n", + "BdiWriteback: %10lu kB\n" + "BdiReclaimable: %10lu kB\n" + "BdiDirtyThresh: %10lu kB\n" + "DirtyThresh: %10lu kB\n" + "BackgroundThresh: %10lu kB\n" + "BdiWritten: %10lu kB\n" + "BdiWriteBandwidth: %10lu kBps\n" + "b_dirty: %10lu\n" + "b_io: %10lu\n" + "b_more_io: %10lu\n" + "bdi_list: %10u\n" + "state: %10lx\n", (unsigned long) K(bdi_stat(bdi, BDI_WRITEBACK)), (unsigned long) K(bdi_stat(bdi, BDI_RECLAIMABLE)), K(bdi_thresh), K(dirty_thresh), K(background_thresh), (unsigned long) K(bdi_stat(bdi, BDI_WRITTEN)), + (unsigned long) bdi->write_bandwidth >> 10, nr_dirty, nr_io, nr_more_io, !list_empty(&bdi->bdi_list), bdi->state); #undef K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 07/13] writeback: show bdi write bandwidth in debugfs Date: Wed, 17 Nov 2010 12:27:27 +0800 Message-ID: <20101117042850.122583518@intel.com> References: <20101117042720.033773013@intel.com> Cc: Jan Kara , Theodore Tso , Peter Zijlstra , Wu Fengguang To: Andrew Morton Return-path: CC: Christoph Hellwig CC: Dave Chinner CC: Chris Mason CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro Cc: linux-mm Cc: Cc: LKML Content-Disposition: inline; filename=writeback-bandwidth-show.patch Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Add a "BdiWriteBandwidth" entry (and indent others) in /debug/bdi/*/stats. btw increase digital field width to 10, for keeping the possibly huge BdiWritten number aligned at least for desktop systems. This will break user space tools if they are dumb enough to depend on the number of white spaces. CC: Theodore Ts'o CC: Jan Kara CC: Peter Zijlstra Signed-off-by: Wu Fengguang --- mm/backing-dev.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) --- linux-next.orig/mm/backing-dev.c 2010-11-15 12:52:34.000000000 +0800 +++ linux-next/mm/backing-dev.c 2010-11-15 12:52:44.000000000 +0800 @@ -87,21 +87,23 @@ static int bdi_debug_stats_show(struct s #define K(x) ((x) << (PAGE_SHIFT - 10)) seq_printf(m, - "BdiWriteback: %8lu kB\n" - "BdiReclaimable: %8lu kB\n" - "BdiDirtyThresh: %8lu kB\n" - "DirtyThresh: %8lu kB\n" - "BackgroundThresh: %8lu kB\n" - "BdiWritten: %8lu kB\n" - "b_dirty: %8lu\n" - "b_io: %8lu\n" - "b_more_io: %8lu\n" - "bdi_list: %8u\n" - "state: %8lx\n", + "BdiWriteback: %10lu kB\n" + "BdiReclaimable: %10lu kB\n" + "BdiDirtyThresh: %10lu kB\n" + "DirtyThresh: %10lu kB\n" + "BackgroundThresh: %10lu kB\n" + "BdiWritten: %10lu kB\n" + "BdiWriteBandwidth: %10lu kBps\n" + "b_dirty: %10lu\n" + "b_io: %10lu\n" + "b_more_io: %10lu\n" + "bdi_list: %10u\n" + "state: %10lx\n", (unsigned long) K(bdi_stat(bdi, BDI_WRITEBACK)), (unsigned long) K(bdi_stat(bdi, BDI_RECLAIMABLE)), K(bdi_thresh), K(dirty_thresh), K(background_thresh), (unsigned long) K(bdi_stat(bdi, BDI_WRITTEN)), + (unsigned long) bdi->write_bandwidth >> 10, nr_dirty, nr_io, nr_more_io, !list_empty(&bdi->bdi_list), bdi->state); #undef K -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 07/13] writeback: show bdi write bandwidth in debugfs Date: Wed, 17 Nov 2010 12:27:27 +0800 Message-ID: <20101117042850.122583518@intel.com> References: <20101117042720.033773013@intel.com> Return-path: Received: from kanga.kvack.org ([205.233.56.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PIZgF-0001bD-UQ for glkm-linux-mm-2@m.gmane.org; Wed, 17 Nov 2010 05:31:36 +0100 Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 512F16B010A for ; Tue, 16 Nov 2010 23:31:31 -0500 (EST) Content-Disposition: inline; filename=writeback-bandwidth-show.patch Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Jan Kara , Theodore Tso , Peter Zijlstra , Wu Fengguang , Christoph Hellwig , Dave Chinner , Chris Mason , Mel Gorman , Rik van Riel , KOSAKI Motohiro , linux-mm , linux-fsdevel@vger.kernel.org, LKML List-Id: linux-mm.kvack.org Add a "BdiWriteBandwidth" entry (and indent others) in /debug/bdi/*/stats. btw increase digital field width to 10, for keeping the possibly huge BdiWritten number aligned at least for desktop systems. This will break user space tools if they are dumb enough to depend on the number of white spaces. CC: Theodore Ts'o CC: Jan Kara CC: Peter Zijlstra Signed-off-by: Wu Fengguang --- mm/backing-dev.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) --- linux-next.orig/mm/backing-dev.c 2010-11-15 12:52:34.000000000 +0800 +++ linux-next/mm/backing-dev.c 2010-11-15 12:52:44.000000000 +0800 @@ -87,21 +87,23 @@ static int bdi_debug_stats_show(struct s #define K(x) ((x) << (PAGE_SHIFT - 10)) seq_printf(m, - "BdiWriteback: %8lu kB\n" - "BdiReclaimable: %8lu kB\n" - "BdiDirtyThresh: %8lu kB\n" - "DirtyThresh: %8lu kB\n" - "BackgroundThresh: %8lu kB\n" - "BdiWritten: %8lu kB\n" - "b_dirty: %8lu\n" - "b_io: %8lu\n" - "b_more_io: %8lu\n" - "bdi_list: %8u\n" - "state: %8lx\n", + "BdiWriteback: %10lu kB\n" + "BdiReclaimable: %10lu kB\n" + "BdiDirtyThresh: %10lu kB\n" + "DirtyThresh: %10lu kB\n" + "BackgroundThresh: %10lu kB\n" + "BdiWritten: %10lu kB\n" + "BdiWriteBandwidth: %10lu kBps\n" + "b_dirty: %10lu\n" + "b_io: %10lu\n" + "b_more_io: %10lu\n" + "bdi_list: %10u\n" + "state: %10lx\n", (unsigned long) K(bdi_stat(bdi, BDI_WRITEBACK)), (unsigned long) K(bdi_stat(bdi, BDI_RECLAIMABLE)), K(bdi_thresh), K(dirty_thresh), K(background_thresh), (unsigned long) K(bdi_stat(bdi, BDI_WRITTEN)), + (unsigned long) bdi->write_bandwidth >> 10, nr_dirty, nr_io, nr_more_io, !list_empty(&bdi->bdi_list), bdi->state); #undef K -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org