From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 5/7] mmc: sdhci-of: support generic OF controllers Date: Tue, 16 Nov 2010 22:36:24 -0700 Message-ID: <20101117053624.GF12813@angua.secretlab.ca> References: <1289939635-30742-1-git-send-email-robherring2@gmail.com> <1289939635-30742-6-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1289939635-30742-6-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Rob Herring Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org On Tue, Nov 16, 2010 at 02:33:53PM -0600, Rob Herring wrote: > From: Rob Herring > > The base sdhci driver requires a valid ops struct. Add empty struct to > sdhci-of to allow generic controllers which don't need custom ops functions. > > Signed-off-by: Rob Herring Applied to my test branch, thanks g. > --- > drivers/mmc/host/sdhci-of-core.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-core.c b/drivers/mmc/host/sdhci-of-core.c > index dd84124..de292fe 100644 > --- a/drivers/mmc/host/sdhci-of-core.c > +++ b/drivers/mmc/host/sdhci-of-core.c > @@ -30,6 +30,9 @@ > #include "sdhci-of.h" > #include "sdhci.h" > > +static struct sdhci_ops sdhci_of_ops = { > +}; > + > #ifdef CONFIG_MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER > > /* > @@ -161,6 +164,8 @@ static int __devinit sdhci_of_probe(struct platform_device *ofdev, > if (sdhci_of_data) { > host->quirks = sdhci_of_data->quirks; > host->ops = &sdhci_of_data->ops; > + } else { > + host->ops = &sdhci_of_ops; > } > > if (of_get_property(np, "sdhci,auto-cmd12", NULL)) > -- > 1.7.1 > > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/devicetree-discuss