diff for duplicates of <20101117145548.GA6794@localhost> diff --git a/a/1.txt b/N1/1.txt index ae59858..834efee 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -53,14 +53,14 @@ anyway. # > /* Tell the MSD to open */ # > - if (wlandev->open != NULL) { # > - result = wlandev->open(wlandev); -# > - if (result = 0) { +# > - if (result == 0) { # > - netif_start_queue(wlandev->netdev); # > - wlandev->state = WLAN_DEVICE_OPEN; # > - } # > - } else { # > - result = -EAGAIN; -# > + if (wlandev->open = NULL) { -# > + printk(KERN_ERR "Sorry, got wlandev->open = NULL.\n"); +# > + if (wlandev->open == NULL) { +# > + printk(KERN_ERR "Sorry, got wlandev->open == NULL.\n"); # This printk is not needed. I haven't looked at this code, but if the # user can trigger this error message then it can be used to flood # /var/log/messages and cause a denial of service attack. @@ -134,7 +134,7 @@ Other things I noticed: return statement. Is this worth of cleaning them up? - When checking skb for NULL, which one is better? (I suppose the former one) - skb = NULL or !skb + skb == NULL or !skb Rewrite occurrences of the other one for cleanup? - drivers/staging/wlan-ng/hfa384x_usb.c +3249 diff --git a/a/content_digest b/N1/content_digest index 91822be..2e9ee71 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020100918204112.GA6236@bicker\0" "From\0Nils Radtke <Nils.Radtke@think-future.de>\0" "Subject\0Re: [PATCH] Staging: wlan-ng: p80211netdev.c cleanup\0" - "Date\0Wed, 17 Nov 2010 14:55:48 +0000\0" + "Date\0Wed, 17 Nov 2010 15:55:48 +0100\0" "To\0Dan Carpenter <error27@gmail.com>\0" "Cc\0gregkh@suse.de" kernel-janitors@vger.kernel.org @@ -65,14 +65,14 @@ "# > \t/* Tell the MSD to open */\n" "# > -\tif (wlandev->open != NULL) {\n" "# > -\t\tresult = wlandev->open(wlandev);\n" - "# > -\t\tif (result = 0) {\n" + "# > -\t\tif (result == 0) {\n" "# > -\t\t\tnetif_start_queue(wlandev->netdev);\n" "# > -\t\t\twlandev->state = WLAN_DEVICE_OPEN;\n" "# > -\t\t}\n" "# > -\t} else {\n" "# > -\t\tresult = -EAGAIN;\n" - "# > +\tif (wlandev->open = NULL) {\n" - "# > +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open = NULL.\\n\");\n" + "# > +\tif (wlandev->open == NULL) {\n" + "# > +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open == NULL.\\n\");\n" "# This printk is not needed. I haven't looked at this code, but if the\n" "# user can trigger this error message then it can be used to flood\n" "# /var/log/messages and cause a denial of service attack.\n" @@ -146,7 +146,7 @@ " return statement. Is this worth of cleaning them up?\n" "\n" "- When checking skb for NULL, which one is better? (I suppose the former one)\n" - " skb = NULL or !skb \n" + " skb == NULL or !skb \n" " Rewrite occurrences of the other one for cleanup?\n" "\n" "- drivers/staging/wlan-ng/hfa384x_usb.c +3249 \n" @@ -160,4 +160,4 @@ "\n" Nils -035409e8714ff6502e0ddefb7e3b2fc0448421427404860b81bbd827a50be516 +386a0f37c20415e45c56d31ef18d926b4b75425213914680ced2ef09ad5c7aa3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.