All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: fix ehci-mxc build.
Date: Wed, 17 Nov 2010 21:25:15 +0100	[thread overview]
Message-ID: <20101117202515.GD8942@pengutronix.de> (raw)
In-Reply-To: <69664.13831.qm@web51001.mail.re2.yahoo.com>

On Tue, Nov 16, 2010 at 06:58:55PM -0800, Fabio Estevam wrote:
> Hi Jiejing,
> 
> --- On Tue, 11/16/10, Zhang Jiejing <jiejing.zhang@freescale.com> wrote:
> 
> > From: Zhang Jiejing <jiejing.zhang@freescale.com>
> > Subject: [PATCH] ARM: imx: fix ehci-mxc build.
> > To: linux-arm-kernel at lists.infradead.org
> > Cc: "Liu Hui" <b29976@freescale.com>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Zhang Jiejing" <jiejing.zhang@freescale.com>, "Daniel Mack" <daniel@caiaq.de>, "Matthieu CASTET" <matthieu.castet@parrot.com>
> > Date: Tuesday, November 16, 2010, 11:57 PM
> > The ehci-mxc.c is broken by commit:
> > 65fd42724aee31018b0bb53f4cb04971423be664
> > 
> > ? CHK? ???include/linux/version.h
> > ? CHK?
> > ???include/generated/utsrelease.h
> > make[1]: `include/generated/mach-types.h' is up to date.
> > ? CALL? ? scripts/checksyscalls.sh
> > ? CHK?
> > ???include/generated/compile.h
> > ? CC? ? ? drivers/serial/imx.o
> > ? LD? ? ? drivers/serial/built-in.o
> > ? CC? ? ? drivers/usb/host/ehci-hcd.o
> > In file included from drivers/usb/host/ehci-hcd.c:1165:
> > drivers/usb/host/ehci-mxc.c: In function
> > 'ehci_mxc_drv_probe':
> > drivers/usb/host/ehci-mxc.c:192: error: 'ehci' undeclared
> > (first use in this function)
> > drivers/usb/host/ehci-mxc.c:192: error: (Each undeclared
> > identifier is reported only once
> > drivers/usb/host/ehci-mxc.c:192: error: for each function
> > it appears in.)
> > drivers/usb/host/ehci-mxc.c:117: warning: unused variable
> > 'temp'
> > make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
> > make[2]: *** [drivers/usb/host] Error 2
> > make[1]: *** [drivers/usb] Error 2
> > make: *** [drivers] Error 2
> > 
> > This patch is fix this by reuse old code.
> 
> Uwe has already sent a fix for this issue: http://git.pengutronix.de/?p=imx/linux-2.6.git;a=commitdiff;h=1cbc09fe2e64ccfb33a4d0e85c46c90a9167a53c
In the meantime gregkh has taken the fix (e.g
724c85251f78f1332e0a28f80cead0cee5b7c906 in current next)

(BTW, your colleague Nguyen Dinh-R00091 tested that patch :-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-11-17 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  1:57 [PATCH] ARM: imx: fix ehci-mxc build Zhang Jiejing
2010-11-17  2:58 ` Fabio Estevam
2010-11-17 20:25   ` Uwe Kleine-König [this message]
2010-11-17  8:04 ` Wolfram Sang
2010-11-17 13:33   ` Zhang Jiejing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117202515.GD8942@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.