Re: [PATCH 2/4] staging: brcm80211: brcmfmac: remove PCI SDIO controller binding

[Greg KH <gregkh@suse.de>]

On Thu, Nov 18, 2010 at 12:00:16AM +0200, Mike Rapoport wrote:
> On Wed, Nov 17, 2010 at 11:10 PM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Nov 17, 2010 at 09:58:46AM +0200, Mike Rapoport wrote:
> >> Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
> >> ---
> >>  drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c |  229 ---------------------
> >>  1 files changed, 0 insertions(+), 229 deletions(-)
> >
> > Wait, is this really ok code to be removing from the driver?
> >
> > Brett and Henry, any objections to this?
> >
> > Mike, why do you think this is ok to remove?  Is it because no one is
> > ever calling this even for both types of config for this driver?
> 
> There's a lot of code in the brcmfmac part of the driver that tries to
> re-implement SDIO stack. In particular, the code removed by this patch
> registers a pci_driver for SDIO controller and then the brcmfmac
> driver accesses the WiFi device attached to that SDIO controller by
> means of custom re-implementation of SDHC.

Ok, so even with this patch, it will still work properly in the SDIO
mode?

Have you been able to test this?

Brett, Henry, I would like to get your ack on this before applying it.

thanks,

greg k-h