From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] target: simplify cmd transformation
Date: Wed, 17 Nov 2010 17:32:07 -0500 [thread overview]
Message-ID: <20101117223207.GC26760@infradead.org> (raw)
In-Reply-To: <1290032519.31890.56.camel@haakon2.linux-iscsi.org>
On Wed, Nov 17, 2010 at 02:21:59PM -0800, Nicholas A. Bellinger wrote:
> On Wed, 2010-11-17 at 16:38 -0500, Christoph Hellwig wrote:
> > There is no need for the transport_cdb_transform function pointer,
> > we can simply call the right code based on the cmd flags.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
>
> Hmmm, it is really less expensive to drop cmd->transport_cdb_transport()
> and change transport_generic_new_cmd() to require 4 bitwise AND instructions
> for each bulk SCF_SCSI_DATA_SG_IO_CDB cmd..?
The pointer bloats every single command in flight, and CPU time is
getting really cheap these days. Either way this will get much simpler
after a few more patches. See the next one for a first preview.
next prev parent reply other threads:[~2010-11-17 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 21:38 [PATCH 1/3] target: simplify cmd transformation Christoph Hellwig
2010-11-17 22:21 ` Nicholas A. Bellinger
2010-11-17 22:32 ` Christoph Hellwig [this message]
2010-11-17 22:46 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117223207.GC26760@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.