From: David Miller <davem@davemloft.net>
To: mlcreech@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Gianfar TCP checksumming broken in 2.6.35+
Date: Thu, 18 Nov 2010 11:34:05 -0800 (PST) [thread overview]
Message-ID: <20101118.113405.116386129.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTi=fZnj94761L_=1DpPAErVG8EHESObtd+d5xJfK@mail.gmail.com>
From: "Matthew L. Creech" <mlcreech@gmail.com>
Date: Thu, 18 Nov 2010 14:31:46 -0500
> On Thu, Nov 18, 2010 at 12:06 PM, David Miller <davem@davemloft.net> =
wrote:
>>
>> Can someone please follow up Matthew to get this bug resolved? =A0It=
has
>> been sitting around for a long time.
>>
>> I suspect the gianfar driver, for these chip revisions, will need to=
>> do a software checksum when the offset matches the criteria mentione=
d
>> in the errata above.
>>
> =
> I added a patch for this which fixes our affected systems; however, I=
> don't know if this is a good way to perform checksum offloading, I
> just kind of dug around until I found a function that seemed like it
> worked. :) Patch against 2.6.36 is below for reference.
It looks fine except I would limit the software checksum to the
exact conditions listed in the errate.
Otherwise this is going to hurt performance and cpu utilization
quite a bit.
next prev parent reply other threads:[~2010-11-18 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:29 Gianfar TCP checksumming broken in 2.6.35+ Matthew L. Creech
2010-11-18 17:06 ` David Miller
2010-11-18 19:31 ` Matthew L. Creech
2010-11-18 19:34 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 7:56 Alex Dubov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118.113405.116386129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mlcreech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.