From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support
Date: Thu, 18 Nov 2010 11:43:03 +0200 [thread overview]
Message-ID: <20101118094303.GK16832@redhat.com> (raw)
In-Reply-To: <201011170929.23005.sheng@linux.intel.com>
On Wed, Nov 17, 2010 at 09:29:22AM +0800, Sheng Yang wrote:
> > > +#define KVM_MSIX_TYPE_ASSIGNED_DEV 1
> > > +
> > > +#define KVM_MSIX_FLAG_MASKBIT (1 << 0)
> > > +#define KVM_MSIX_FLAG_QUERY_MASKBIT (1 << 0)
> > > +
> > > +struct kvm_msix_entry {
> > > + __u32 id;
> > > + __u32 type;
> >
> > Is type really necessary? Will it ever differ from
> > KVM_MSIX_TYPE_ASSIGNED_DEV?
>
> This is the suggestion from Michael. He want it to be reused by emulated/pv
> devices. So I add the type field here.
Maybe id field can be reused for this somehow.
--
MST
next prev parent reply other threads:[~2010-11-18 9:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 9:15 [PATCH 0/6 v5] MSI-X mask support for assigned device Sheng Yang
2010-11-15 9:15 ` [PATCH 1/6] PCI: MSI: Move MSI-X entry definition to pci_regs.h Sheng Yang
2010-11-15 9:15 ` [PATCH 2/6] PCI: Add mask bit definition for MSI-X table Sheng Yang
2010-11-15 9:15 ` [PATCH 3/6] KVM: Move struct kvm_io_device to kvm_host.h Sheng Yang
2010-11-15 9:15 ` [PATCH 4/6] KVM: Add kvm_get_irq_routing_entry() func Sheng Yang
2010-11-17 14:01 ` Avi Kivity
2010-11-18 2:22 ` Sheng Yang
2010-11-18 9:30 ` Avi Kivity
2010-11-18 9:41 ` Michael S. Tsirkin
2010-11-18 11:59 ` Sheng Yang
2010-11-18 12:33 ` Michael S. Tsirkin
2010-11-18 12:40 ` Sheng Yang
2010-11-15 9:15 ` [PATCH 5/6] KVM: assigned dev: Clean up assigned_device's flag Sheng Yang
2010-11-15 9:15 ` [PATCH 6/6] KVM: assigned dev: MSI-X mask support Sheng Yang
2010-11-15 9:27 ` [PATCH 6/6 v5 updated] " Sheng Yang
2010-11-16 19:45 ` [PATCH 6/6] " Marcelo Tosatti
2010-11-17 1:29 ` Sheng Yang
2010-11-17 13:35 ` Marcelo Tosatti
2010-11-18 9:43 ` Michael S. Tsirkin [this message]
2010-11-17 13:58 ` Avi Kivity
2010-11-18 1:58 ` Sheng Yang
2010-11-18 6:21 ` Michael S. Tsirkin
2010-11-18 6:39 ` Sheng Yang
2010-11-18 9:28 ` Avi Kivity
2010-11-18 9:37 ` Michael S. Tsirkin
2010-11-18 12:08 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118094303.GK16832@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.