From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
acme@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf: Fix compilation on gcc 4.0.2
Date: Thu, 18 Nov 2010 14:40:38 +0100 [thread overview]
Message-ID: <20101118134038.GE12667@basil.fritz.box> (raw)
In-Reply-To: <1290087489.2781.121.camel@edumazet-laptop>
On Thu, Nov 18, 2010 at 02:38:09PM +0100, Eric Dumazet wrote:
> Le jeudi 18 novembre 2010 à 14:31 +0100, Andi Kleen a écrit :
> > > Should we be using more of the kernel makefile magic to detect this?
> >
> > In theory yes, but the two warnings didn't seem to be too useful
> > to me so it's probably not worth it just for those two.
> >
> > -Andi
> >
>
> Is the second case because of the __always_inline in
> util/include/linux/bitops.h ?
I think so.
>
> Not sure why its needed for test_bit() ?
Because it generates terrible code when not inlined
and apparently some gcc versions of times past didn't
in some cases.
-Andi
next prev parent reply other threads:[~2010-11-18 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 10:50 Some perf user space improvements Andi Kleen
2010-11-18 10:51 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 Andi Kleen
2010-11-18 11:15 ` Peter Zijlstra
2010-11-18 13:31 ` Andi Kleen
2010-11-18 13:38 ` Eric Dumazet
2010-11-18 13:40 ` Andi Kleen [this message]
2010-11-19 9:51 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 v2 Andi Kleen
2010-11-18 11:53 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 Thomas Gleixner
2010-11-18 10:51 ` [PATCH 2/2] perf: Handle perf-versionnumber Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118134038.GE12667@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.