Re: [Qemu-devel] Re: [PATCH] spice: add qxl device

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Nov 18, 2010 at 06:10:12PM +0200, Gleb Natapov wrote:
> > WHQL includes surprise removal tests. So any card that passed
> > that will work with surprise removal.
> > 
> Yeah. But it is not real "surprise removal". It will not crash qemu.

That was the problem I saw. That the way qxl is written, surprise
removal could crash qemu.

> > > > I expect surprise removal to be of most use for
> > > > assigned devices. But even for emulated devices, we have a small
> > > > number of slots available, so it would still be useful to free up the PCI slot,
> > > > even if guest needs to be rebooted then.
> > > > 
> > > We are talking about should we require primary VGA to be
> > > hot-unplaggable. The last thing you want to remove to free PCI slots is
> > > primary VGA card especially if no guest OS can handle it ;)
> > 
> > What I am saying is we need surprise removal generally.
> For all HW that we allow to remove from monitor sure.
> 
> > If won't be too bad if we make these commands fail for VGA.
> > 
> The patch is on the list already.

That's good. If my review is needed, Cc me so it won't get lost
in the noise.

-- 
MST