From: Jonathan Nieder <jrnieder@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH 2/2] A loose object is not corrupt if it cannot be read due to EMFILE
Date: Thu, 18 Nov 2010 11:29:20 -0600 [thread overview]
Message-ID: <20101118172920.GC16610@burratino> (raw)
In-Reply-To: <AANLkTikns0Rm5znC7FOa72qZXKpQzazKiYsPe-oDNMAk@mail.gmail.com>
Erik Faye-Lund wrote:
> I was wondering about the same thing, I don't think this approach is
> very easy to follow. But either way I think we should make sure
> opendir/closedir/readdir doesn't mess with errno.
Other platforms and are allowed to (and do) clobber errno in many
non-error situations, so the main effect would be to work around/hide
some git bugs.
For mingw-runtime, the balance might be different. Making buggy,
non-portable application code easier to port does not sound like a bad
thing.
Just my two cents,
Jonathan
next prev parent reply other threads:[~2010-11-18 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:53 [PATCH 1/2] read_sha1_file(): report correct name of packfile with a corrupt object Junio C Hamano
2010-10-28 20:53 ` [PATCH 2/2] A loose object is not corrupt if it cannot be read due to EMFILE Junio C Hamano
2010-11-18 14:19 ` Erik Faye-Lund
2010-11-18 16:43 ` Johannes Sixt
2010-11-18 17:21 ` Erik Faye-Lund
2010-11-18 17:29 ` Jonathan Nieder [this message]
2010-11-18 18:18 ` Erik Faye-Lund
2010-11-18 18:23 ` Casey Dahlin
2010-11-18 20:27 ` Jonathan Nieder
2010-10-29 8:08 ` [PATCH 1/2] read_sha1_file(): report correct name of packfile with a corrupt object Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118172920.GC16610@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.