All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: linux-omap@vger.kernel.org, Vishwanath BS <vishwanath.bs@ti.com>,
	Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH 2/2] OMAP3: clean up ASM idle code
Date: Thu, 18 Nov 2010 09:41:18 -0800	[thread overview]
Message-ID: <20101118174118.GD9264@atomide.com> (raw)
In-Reply-To: <1290091906-32539-3-git-send-email-j-pihet@ti.com>

* Jean Pihet <jean.pihet@newoldbits.com> [101118 06:43]:
> From: Vishwanath BS <vishwanath.bs@ti.com>
> 
> Clean up of the ASM code:
> - reworked and simplified the execution paths, for better
>    readability and to avoid duplication of code,
> - reworked the comments for better readability,
> - reworked the code formating and alignment,
> - added comments for the i443 errata workarounds,
> - replaced the cache flush code by a call to the kernel
>    common code for ARMv7 (v7_flush_kern_cache_all), which is
>    better maintained and so more mature,
> - clean up of non used symbols.

This should be broken into several patches.

The first patch should be to use v7_flush_kern_cache_all
instead of the buggy older copy of that in sleep34xx.S.

After that, any readability and formatting patches should
contain no functional changes.

Regards,

Tony

  reply	other threads:[~2010-11-18 17:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 14:51 OMAP3 sleep code clean-up Jean Pihet
2010-11-18 14:51 ` [PATCH 1/2] OMAP3 PM: move omap3 sleep to ddr Jean Pihet
2010-11-18 14:57   ` Nishanth Menon
2010-11-18 15:08     ` Sripathy, Vishwanath
2010-11-18 15:11       ` Nishanth Menon
2010-11-18 15:15         ` Jean Pihet
2010-11-18 15:33           ` Nishanth Menon
2010-11-18 15:52     ` Kevin Hilman
2010-11-18 16:55       ` Nishanth Menon
2010-11-18 17:52         ` Tony Lindgren
2010-11-18 18:13           ` Tony Lindgren
2010-11-18 18:15           ` Jean Pihet
2010-11-18 18:27             ` Tony Lindgren
2010-11-18 18:34               ` Jean Pihet
2010-11-19 15:37                 ` Jean Pihet
2010-11-19 16:09                   ` Tony Lindgren
2010-11-19 16:14                   ` Derrick, David
2010-11-19 16:26                     ` Jean Pihet
2010-11-22 10:07                     ` Peter 'p2' De Schrijver
2010-11-22 16:03                       ` Kevin Hilman
2010-11-22 16:08                         ` Jean Pihet
2010-11-22 16:22                         ` Peter 'p2' De Schrijver
2010-11-22 16:25                           ` Nishanth Menon
2010-11-22 18:23                             ` Kevin Hilman
2010-11-22 18:31                               ` Nishanth Menon
2010-11-18 14:51 ` [PATCH 2/2] OMAP3: clean up ASM idle code Jean Pihet
2010-11-18 17:41   ` Tony Lindgren [this message]
2010-11-18 18:19     ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118174118.GD9264@atomide.com \
    --to=tony@atomide.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.