All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, mingo@elte.hu,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] x86, nmi_watchdog: Remove the old nmi_watchdog
Date: Thu, 18 Nov 2010 15:02:50 -0500	[thread overview]
Message-ID: <20101118200250.GB8131@redhat.com> (raw)
In-Reply-To: <4CE58106.5070009@kernel.org>

On Thu, Nov 18, 2010 at 11:39:50AM -0800, Yinghai Lu wrote:
> > 
> > Please update the kernel-parameters.txt accordingly.
> > 
> > and you need to keep unknown_nmi_panic or else as early_param().
> > 
> > Also any corresponding part like "nmi_watchdog=off" ?
> > 
> 
> also you have some other left-over...
> 
> Documentation/kernel-parameters.txt:    unknown_nmi_panic
> Documentation/kernel-parameters.txt:                    Set unknown_nmi_panic=1 early on boot.
> Documentation/sysctl/kernel.txt:- unknown_nmi_panic
> Documentation/sysctl/kernel.txt:unknown_nmi_panic:
> arch/x86/include/asm/nmi.h:extern int unknown_nmi_panic;
> arch/x86/kernel/apic/hw_nmi.c:int unknown_nmi_panic;
> kernel/sysctl_binary.c: { CTL_INT,      KERN_UNKNOWN_NMI_PANIC,         "unknown_nmi_panic" },
> 
> may still have left for nmi_watchdog too.

Yes the first part of the patch left in stubs.  The second piece should
clean up stuff like nmi_watchdog.

On the other side unknown_nmi_panic is actually going to be added back in
with another patch that re-arranges the default_do_nmi() call that I
posted in another patch series.

Cheers,
Don

  reply	other threads:[~2010-11-18 20:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 16:22 [PATCH 0/2] x86: Remove old nmi_watchdog Don Zickus
2010-11-12 16:22 ` [PATCH 1/2] x86, nmi_watchdog: remove the " Don Zickus
2010-11-18 14:05   ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-18 19:11     ` Yinghai Lu
2010-11-18 19:39       ` Yinghai Lu
2010-11-18 20:02         ` Don Zickus [this message]
2010-11-18 20:07           ` Yinghai Lu
2010-11-12 16:22 ` [PATCH 2/2] x86, nmi_watchdog: remove all stub function calls from " Don Zickus
2010-11-18 14:05   ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-12 18:04 ` [PATCH 0/2] x86: Remove " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118200250.GB8131@redhat.com \
    --to=dzickus@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.