From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, hagen@jauu.net, netdev@vger.kernel.org,
xiaosuo@gmail.com
Subject: Re: [PATCH net-next-2.6] filter: optimize sk_run_filter
Date: Fri, 19 Nov 2010 09:15:37 -0800 [thread overview]
Message-ID: <20101119091537.5d1fed2e@nehalam> (raw)
In-Reply-To: <20101119.090516.104057453.davem@davemloft.net>
On Fri, 19 Nov 2010 09:05:16 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 19 Nov 2010 17:55:59 +0100
>
> > Unfortunatly on x86_32 it also chose that f_k was more valuable in a cpu
> > register and accumulator A lost its register to get a stack slot
> > instead.
>
> Ok that tradeoff is terrible, but it depends upon knowledge we haven't
> given to the compiler (yet).
>
> Let me think about this a bit...
Are 'register' modifiers a no-op on current GCC?
next prev parent reply other threads:[~2010-11-19 17:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 2:04 [PATCH] net: reduce the lines of code Changli Gao
2010-11-19 6:35 ` Hagen Paul Pfeifer
2010-11-19 7:17 ` Changli Gao
2010-11-19 7:51 ` Eric Dumazet
2010-11-19 7:56 ` [PATCH net-next-2.6] filter: cleanup codes[] init Eric Dumazet
2010-11-19 8:04 ` [PATCH net-next-2.6] filter: use reciprocal divide Eric Dumazet
2010-11-19 8:18 ` Changli Gao
2010-11-19 18:07 ` David Miller
2010-11-19 8:38 ` [PATCH net-next-2.6] filter: cleanup codes[] init Changli Gao
2010-11-19 9:54 ` Eric Dumazet
2010-11-19 11:17 ` [PATCH net-next-2.6] filter: optimize sk_run_filter Eric Dumazet
2010-11-19 12:32 ` Changli Gao
2010-11-19 12:57 ` Changli Gao
2010-11-19 13:16 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2010-11-19 14:13 ` Changli Gao
2010-11-19 17:52 ` David Miller
2010-11-19 14:17 ` Tetsuo Handa
2010-11-19 14:35 ` Eric Dumazet
2010-11-19 16:21 ` [PATCH net-next-2.6] " David Miller
2010-11-19 16:55 ` Eric Dumazet
2010-11-19 17:05 ` David Miller
2010-11-19 17:15 ` Stephen Hemminger [this message]
2010-11-19 17:21 ` David Miller
2010-11-19 17:16 ` Eric Dumazet
2010-11-19 17:25 ` David Miller
2010-11-19 12:21 ` [PATCH net-next-2.6] filter: cleanup codes[] init Changli Gao
2010-11-19 18:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119091537.5d1fed2e@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.