From: jajones@nvidia.com (James Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix find_next_zero_bit and related assembly
Date: Fri, 19 Nov 2010 10:13:20 -0800 [thread overview]
Message-ID: <201011191013.20983.jajones@nvidia.com> (raw)
The find_next_bit, find_first_bit, find_next_zero_bit
and find_first_zero_bit functions were not properly
clamping to the maxbit argument at the bit level. They
were instead only checking maxbit at the byte level.
To fix this, add a compare and a conditional move
instruction to the end of the common bit-within-the-
byte code used by all the functions and be sure not to
clobber the maxbit argument before it is used.
Signed-off-by: James Jones <jajones@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/lib/findbit.S | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/lib/findbit.S b/arch/arm/lib/findbit.S
index 1e4cbd4..64f6bc1 100644
--- a/arch/arm/lib/findbit.S
+++ b/arch/arm/lib/findbit.S
@@ -174,8 +174,8 @@ ENDPROC(_find_next_bit_be)
*/
.L_found:
#if __LINUX_ARM_ARCH__ >= 5
- rsb r1, r3, #0
- and r3, r3, r1
+ rsb r0, r3, #0
+ and r3, r3, r0
clz r3, r3
rsb r3, r3, #31
add r0, r2, r3
@@ -190,5 +190,7 @@ ENDPROC(_find_next_bit_be)
addeq r2, r2, #1
mov r0, r2
#endif
+ cmp r1, r0 @ Clamp to maxbit
+ movlo r0, r1
mov pc, lr
--
1.7.1
next reply other threads:[~2010-11-19 18:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:13 James Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-12 1:16 [PATCH] ARM: Fix find_next_zero_bit and related assembly James Jones
2010-11-23 21:26 ` Nicolas Pitre
2010-11-23 21:26 ` Nicolas Pitre
2010-11-23 23:28 ` James Jones
2010-11-23 23:28 ` James Jones
2010-11-24 18:12 ` Stephen Boyd
2010-11-24 18:12 ` Stephen Boyd
2010-11-24 19:00 ` Nicolas Pitre
2010-11-24 19:00 ` Nicolas Pitre
2010-11-24 19:08 ` James Jones
2010-11-24 19:08 ` James Jones
2010-11-24 19:13 ` Nicolas Pitre
2010-11-24 19:13 ` Nicolas Pitre
2010-11-24 19:15 ` Russell King - ARM Linux
2010-11-24 19:15 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011191013.20983.jajones@nvidia.com \
--to=jajones@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.