From: Greg KH <gregkh@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Pavel Machek <pavel@ucw.cz>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: fix winbond build, needs delay.h
Date: Fri, 19 Nov 2010 09:54:43 -0800 [thread overview]
Message-ID: <20101119175443.GA6326@suse.de> (raw)
In-Reply-To: <4CE6B87C.2010203@oracle.com>
On Fri, Nov 19, 2010 at 09:48:44AM -0800, Randy Dunlap wrote:
> On 11/19/10 09:38, Greg KH wrote:
> > On Fri, Nov 19, 2010 at 09:30:18AM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> winbond drivers use msleep() and delay(), so include linux/delay.h
> >> in a common header file to prevent build errors.
> >>
> >> drivers/staging/winbond/phy_calibration.c:987: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/phy_calibration.c:1556: error: implicit declaration of function 'udelay'
> >> drivers/staging/winbond/reg.c:894: error: implicit declaration of function 'msleep'
> >> drivers/staging/winbond/reg.c:1178: error: implicit declaration of function 'udelay'
> >
> > Is this error showing up in Linus's tree, or only in linux-next?
>
> I saw it in linux-next, but it looks like it should also be a build error
> in mainline.
Ok, thanks, I'll queue it up for Linus's tree then.
greg k-h
next prev parent reply other threads:[~2010-11-19 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 3:32 linux-next: Tree for November 19 Stephen Rothwell
2010-11-19 17:15 ` linux-next: Tree for November 19 (sched_fair) Randy Dunlap
2010-11-19 17:16 ` linux-next: Tree for November 19 (rtmutex) Randy Dunlap
2010-12-02 19:52 ` Randy Dunlap
2010-11-19 17:30 ` [PATCH -next] staging: fix winbond build, needs delay.h Randy Dunlap
2010-11-19 17:37 ` Pavel Machek
2010-11-19 17:38 ` Greg KH
2010-11-19 17:48 ` Randy Dunlap
2010-11-19 17:54 ` Greg KH [this message]
2010-11-19 17:40 ` linux-next: Tree for November 19 Zimny Lech
2010-11-19 17:42 ` Alan Cox
2010-11-19 18:35 ` Zimny Lech
2010-11-20 5:50 ` Zimny Lech
2010-11-20 5:52 ` Zimny Lech
2010-11-20 10:44 ` Jens Axboe
2010-11-20 7:15 ` Zimny Lech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119175443.GA6326@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.