From: Chris Ball <cjb@laptop.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org, Daniel Drake <dsd@laptop.org>
Subject: Re: [PATCH] sdio: fix nasty oops in mmc_sdio_detect
Date: Fri, 19 Nov 2010 22:06:39 +0000 [thread overview]
Message-ID: <20101119220639.GC19272@void.printf.net> (raw)
In-Reply-To: <1289731233-19996-1-git-send-email-ohad@wizery.com>
Hi Ohad,
On Sun, Nov 14, 2010 at 12:40:33PM +0200, Ohad Ben-Cohen wrote:
> Power off the card in mmc_sdio_detect __before__ a potential error
> handler, which completely removes the card, executes, and only if the
> card was successfully powered on beforehand.
>
> While we're at it, use the _sync variant of the runtime PM put API, in
> order to ensure that the card is left powered off in case an error
> occurred, and the card is going to be removed.
>
> Reproduced and tested on the XO-1.5.
>
> Reported-by: Daniel Drake <dsd@laptop.org>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Thanks, pushed to for-linus/mmc-next for 2.6.37.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2010-11-19 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 10:40 [PATCH] sdio: fix nasty oops in mmc_sdio_detect Ohad Ben-Cohen
2010-11-19 22:06 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119220639.GC19272@void.printf.net \
--to=cjb@laptop.org \
--cc=dsd@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.