diff for duplicates of <20101119222823.GA28797@quadria> diff --git a/a/1.txt b/N1/1.txt index 394d301..8f86bb0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ Absolutely, I should have mentioned it in the patch description. > - (__x < 0) ? -__x : __x; \ > +#define abs(x) ({ \ > + long ret; \ -> + if (sizeof(x) = sizeof(long)) { \ +> + if (sizeof(x) == sizeof(long)) { \ > + long __x = (x); \ > + ret = (__x < 0) ? -__x : __x; \ > + } else { \ @@ -47,7 +47,7 @@ Absolutely, I should have mentioned it in the patch description. > _ Looks good to me. I posted essentially the same thing some 3 months ago -(http://marc.info/?l=linux-kernel&m\x128033094822201&w=2) but it then +(http://marc.info/?l=linux-kernel&m=128033094822201&w=2) but it then failed to get any traction. At any rate, I like your version better as it seems more readable. diff --git a/a/content_digest b/N1/content_digest index c2daaba..acc0c8d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\0AANLkTimYDAJr9x00sjGGnDF2vOVXU12qmbnmfuzA5_0h@mail.gmail.com\0" "ref\020101119140721.33576c61.akpm@linux-foundation.org\0" "From\0Michal Januszewski <michalj@gmail.com>\0" - "Subject\0Re: abs() vs. abs64() (was: Re: [PATCH] fbdev: fix nearest mode\0" - "Date\0Fri, 19 Nov 2010 22:28:23 +0000\0" + "Subject\0Re: abs() vs. abs64() (was: Re: [PATCH] fbdev: fix nearest mode search)\0" + "Date\0Fri, 19 Nov 2010 23:28:23 +0100\0" "To\0Andrew Morton <akpm@linux-foundation.org>\0" "Cc\0Geert Uytterhoeven <geert@linux-m68k.org>" Rolf Eike Beer <eike-kernel@sf-tec.de> @@ -45,7 +45,7 @@ "> -\t\t(__x < 0) ? -__x : __x;\t\t\\\n" "> +#define abs(x) ({\t\t\t\t\t\t\\\n" "> +\t\tlong ret;\t\t\t\t\t\\\n" - "> +\t\tif (sizeof(x) = sizeof(long)) {\t\t\\\n" + "> +\t\tif (sizeof(x) == sizeof(long)) {\t\t\\\n" "> +\t\t\tlong __x = (x);\t\t\t\t\\\n" "> +\t\t\tret = (__x < 0) ? -__x : __x;\t\t\\\n" "> +\t\t} else {\t\t\t\t\t\\\n" @@ -59,10 +59,10 @@ "> _\n" "\n" "Looks good to me. I posted essentially the same thing some 3 months ago\n" - "(http://marc.info/?l=linux-kernel&m\0228033094822201&w=2) but it then\n" + "(http://marc.info/?l=linux-kernel&m=128033094822201&w=2) but it then\n" "failed to get any traction. At any rate, I like your version better as\n" "it seems more readable.\n" "\n" Michal -9735407c09a9a86293dc00d6a3361ed86b9319f6c01167d01bf3a9ea30576d01 +15a0dd649f5b200ac5dea2450972b911edd803a37d07fc60bcf2a0dcb2acaa20
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.