All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	a.p.zijlstra@chello.nl, fweisbec@gmail.com, michaele@au1.ibm.com,
	ianmunsi@au1.ibm.com
Subject: Re: [PATCH] perf: Change and clean up sys_perf_event_open error handling
Date: Sat, 20 Nov 2010 15:13:34 -0200	[thread overview]
Message-ID: <20101120171334.GB29710@ghostprotocols.net> (raw)
In-Reply-To: <1290217044-26293-1-git-send-email-cjashfor@linux.vnet.ibm.com>

Em Fri, Nov 19, 2010 at 05:37:24PM -0800, Corey Ashford escreveu:
> This patch makes several changes to "perf stat":
> 
> - "perf stat" will no longer go ahead and run the application when one or
> more of the specified events could not be opened.
> - Use error() and die() instead of pr_err() so that the output is more
> consistent with "perf top" and "perf record".
> - Handle permission errors in a more robust way, and in a similar way to
> "perf record" and "perf top".
> 
> In addition, the sys_perf_event_open() error handling of "perf top" and
> "perf record" is made more consistent and adds the following phrase when an
> event doesn't open (with something ther than an access or permission
> error):

Thanks, applied.

Ingo, this one is in my perf/core branch, in addition to the 3 patches I
posted yesterday.

- Arnaldo

  reply	other threads:[~2010-11-20 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20  1:37 [PATCH] perf: Change and clean up sys_perf_event_open error handling Corey Ashford
2010-11-20 17:13 ` Arnaldo Carvalho de Melo [this message]
2010-11-21 13:43 ` [tip:perf/core] perf stat: " tip-bot for Corey Ashford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101120171334.GB29710@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=ianmunsi@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaele@au1.ibm.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.